Skip to content

Incorrect order total is passed to Viva payments from Magento 2 store with multiple currencies #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ddcdom opened this issue Nov 14, 2019 · 2 comments
Closed

Incorrect order total is passed to Viva payments from Magento 2 store with multiple currencies #1212

Ddcdom opened this issue Nov 14, 2019 · 2 comments
Labels
e-commerce plugin

Comments

@Ddcdom
Copy link
Contributor

Ddcdom commented Nov 14, 2019

The order total passed to Viva for authorisation from the Magento 2.3 plugin is GrandTotal, not BaseGrandTotal. GrandTotal is the value in the store's display currency, not the store's base currency.

I've created pull request #1211 to fix this issue. Please note these changes are untested.
@Ddcdom
Copy link
Contributor Author

Ddcdom commented Nov 19, 2019

I've now tested my change and can confirm that they work as expected.
Please can you accept my pull request?

@VivaWalletSupport
Copy link
Contributor

Thank you for bringing this up. For your situation this modification might work (to always use the stores default currency). In a preferred setup, using various currencies with various Viva accounts, this mod will be a problem.

@Ddcdom Ddcdom mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e-commerce plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ddcdom @VivaWalletSupport @matthewrgourd