This repository was archived by the owner on Sep 2, 2024. It is now read-only.
This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Vocal attempts to sync with gpodder even if not logged in #470
Description
Prerequisites
- I have searched the Issues list for open and closed issues and believe this is a unique, currently unreported bug.
Describe the bug
Vocal will attempt to sync episode progress with gpodder (https://gpodder.net/api/2/episodes/.json would normally have a username if authenticated) even if a user is not logged in. This spams the logs with messages like Failed to update progress in gpodder.net for ... and results in unnecessary HTTP requests originating from the application.
To Reproduce
Steps to reproduce the behavior:
- Start Vocal from the command line with
com.github.needleandthread.vocal - Select any episode to play
- Watch the logs for these
failedmessages
Expected behavior
If a user does not provide gpodder.net credentials, I'd expect the application to skip any gpodder.net actions instead of trying and failing.
Screenshots or screen recordings
Logs
[INFO 15:43:42.898538] Player.vala:109: Setting playback URI: https://traffic.omny.fm/d/clips/aaea4e69-af51-495e-afc9-a9760146922b/c4180e0a-f36c-464c-a963-ab050184b0cd/1a5ba7be-b56d-4586-8b5c-ac4a01001288/audio.mp3?utm_source=Podcast&in_playlist=25520209-5e60-4aa4-aa3c-ab050184b0d7
[INFO 15:43:42.899594] MainWindow.vala:685: Creating coverart for each podcast in library.
[INFO 15:43:43.031888] DirectoryView.vala:129: Top 100 podcasts loaded.
[INFO 15:43:43.428123] MainWindow.vala:727: Adding coverart to view.
[INFO 15:43:43.551364] Controller.vala:652: Checking for updates.
[INFO 15:43:43.551891] Library.vala:463: updating feed https://www.omnycontent.com/d/playlist/aaea4e69-af51-495e-afc9-a9760146922b/c4180e0a-f36c-464c-a963-ab050184b0cd/25520209-5e60-4aa4-aa3c-ab050184b0d7/podcast.rss
[WARNING 15:43:44.249998] ImageCache.vala:90: Failed to load image. Service https://is1-ssl.mzstatic.com/image/thumb/Podcasts114/v4/5c/86/ec/5c86ecdb-9600-32e8-c2fb-da5e98331a2c/mza_2054748440601491605.jpeg/600x600bb.png returned HTTP status code 404 Not Found
[INFO 15:43:49.646505] gpodderClient.vala:511: 0
[INFO 15:43:49.996646] gpodderClient.vala:548: <html><head><title>404 Not Found</title></head><body bgcolor="white"><center><h1>404 Not Found</h1></center><hr><center>nginx/1.14.0 (Ubuntu)</center></body></html>
[INFO 15:43:49.996780] gpodderClient.vala:549: 404
[INFO 15:43:49.997022] gpodderClient.vala:555: Failed to update progress in gpodder.net for Leslie Vosshall – Why Mosquitoes Choose You
Platform Information
Please share as many of the following details as possible:
- Linux distrubution: NixOS
- OS version: unstable
- Desktop environment: GNOME 3.36
Please check the applicable option below:
- I'm using the latest version from git that I've manually compiled
- I'm using the latest version of the Flatpak, downloaded from Flathub.org
- I'm using the latest version available from AppCenter
- I'm using a different version (please note here) :