Incompatible with Selenoid

[grelner]

I've been trying to use thirtyfour with selenoid but the call to WebDriver::new fails.
The selenoid session api call is at /wd/hub/session while thirtyfour will always call /session . The reason is that thirtyfour uses Url::join to resolve url's with an argument that starts with '/'. Given webdriver url "http://localhost:4444/wd/hub" and "/session", Url::join will return http://localhost:4444/session
Personally I find the behavior of Url::join confusing, especially compared to Path::join, so this might not be intended behaviour?

[mallocdev]

@grelner Did you manage to use selenoid with thirtyfour?

[grelner]

@grelner Did you manage to use selenoid with thirtyfour?

Hi! Yes! The necessary patches are in my fork https://github.com/grelner/thirtyfour
This project was unmaintained back when I ran into this problem, that's why the patch just sits in my fork. But it seems there's a new maintainer now, so I'll make a PR when I'm back from vacation in a week so this gets moved into the main repo

[Vrtgs]

looking forward to it!

[Vrtgs]

any updates on this?