Skip to content

Conversation

@webJose
Copy link
Contributor

@webJose webJose commented Nov 27, 2025

BREAKING CHANGE

@webJose webJose requested a review from Copilot November 27, 2025 21:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the noMatches property to fallback across the codebase and changes the resolvedHash property from private to public in the RouterEngine class. These are breaking changes that improve API clarity by using more intuitive naming.

Key changes:

  • Renamed noMatches to fallback throughout the codebase (property, variables, documentation)
  • Changed #resolvedHash from private to public resolvedHash property
  • Updated all references in types, tests, and documentation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib/types.ts Updated WhenPredicate type signature parameter from noMatches to fallback
src/lib/kernel/RouterEngine.svelte.ts Changed #resolvedHash to public resolvedHash and renamed noMatches property/variables to fallback
src/lib/kernel/RouterEngine.svelte.test.ts Updated test suite to use fallback instead of noMatches
src/lib/Fallback/README.md Updated documentation to reference fallback instead of noMatches
src/lib/Fallback/Fallback.svelte Updated component logic to use router.fallback instead of router.noMatches
AGENTS.md Updated agent documentation to reflect the fallback terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webJose webJose merged commit 192db0d into main Nov 27, 2025
1 check passed
@webJose webJose deleted the JP/RouterTrace branch November 27, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants