From 9c32bafd7dd07323ba977f21329ffb9c1fc5634e Mon Sep 17 00:00:00 2001
From: Gabriele De Rosa <derosagabriele@outlook.it>
Date: Thu, 7 May 2026 14:35:51 +0200
Subject: [PATCH] fix(changelog): filter no-op dependency update bullets

---
 README.md                         |  4 ++--
 action.yml                        |  2 +-
 scripts/normalize_changelog.py    | 30 ++++++++++++++++++++++++-
 tests/test_normalize_changelog.py | 37 +++++++++++++++++++++++++++++++
 4 files changed, 69 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 2bd883c..4cadf75 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@ GitHub Action to generate a `CHANGELOG.md` on new tags, with optional Telegram n
 
 ## Breaking changes in 2.x
 
-- The action now lives at the repository root and is used as `Waveful/ChangelogAction@v2.0.3`.
+- The action now lives at the repository root and is used as `Waveful/ChangelogAction@v2.0.4`.
 - The old split actions (`/generate`, `/notify`, `/annotate`) have been removed from the default setup.
 - Changelog generation is always the default behavior.
 - Telegram notification only runs when `telegram-bot-token`, `telegram-chat-id`, and `changelog-url` are all provided.
@@ -67,7 +67,7 @@ jobs:
     steps:
       - name: Run changelog action
         id: changelog
-        uses: Waveful/ChangelogAction@v2.0.3
+        uses: Waveful/ChangelogAction@v2.0.4
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           target-branch: master
diff --git a/action.yml b/action.yml
index 7c2a154..9d42532 100644
--- a/action.yml
+++ b/action.yml
@@ -264,7 +264,7 @@ runs:
         Before writing, read all provided information and identify the distinct changes.
         PR details and commit details may overlap; combine them, do not duplicate.
         Merge multiple items addressing the same feature, bug, or area into a single bullet.
-        Put all PRs and commits whose only changes are dependency updates into one single bullet, formatted as "Update some dependencies (X, Y, Z)" with the updated dependency names in place of X, Y, Z.
+        Put all PRs and commits whose only changes are dependency updates into one single bullet, formatted as "Update some dependencies (X, Y, Z)" with the updated dependency names in place of X, Y, Z. Only add this bullet when at least one dependency was actually updated; never write "(none)", "(unknown)", or empty parentheses.
         Never describe the same change more than once.
         Focus on what changed from the user's perspective rather than listing every commit or PR.
 
diff --git a/scripts/normalize_changelog.py b/scripts/normalize_changelog.py
index d10fe72..b027e9c 100644
--- a/scripts/normalize_changelog.py
+++ b/scripts/normalize_changelog.py
@@ -10,6 +10,16 @@
 from pathlib import Path
 
 
+NOOP_DEPENDENCY_BULLET_RE = re.compile(
+    r"^[ \t]*(?:[•*-]|\d+[.)])[ \t]+"
+    r"(?:update(?:d|s)?|bump(?:ed|s)?|upgrade(?:d|s)?)\s+"
+    r"(?:some\s+)?dependenc(?:y|ies)\s*"
+    r"\(\s*(?:none|n/?a|not applicable|no dependencies?)\s*\)"
+    r"[.!?]?[ \t]*$",
+    flags=re.IGNORECASE | re.MULTILINE,
+)
+
+
 def normalize(text):
     # Ensure blank line before ## headings (when not already preceded by one)
     text = re.sub(r"(?<!\n)\n(## )", r"\n\n\1", text)
@@ -22,6 +32,23 @@ def normalize(text):
     return text
 
 
+def remove_noop_dependency_bullets(text):
+    return "\n".join(
+        line for line in text.splitlines() if not NOOP_DEPENDENCY_BULLET_RE.match(line)
+    )
+
+
+CHANGELOG_FILTERS = (
+    remove_noop_dependency_bullets,
+)
+
+
+def filter_changelog(text):
+    for changelog_filter in CHANGELOG_FILTERS:
+        text = changelog_filter(text)
+    return text
+
+
 def main():
     parser = argparse.ArgumentParser(description="Normalize changelog markdown in-place.")
     parser.add_argument("file", help="Markdown file to normalize")
@@ -29,7 +56,8 @@ def main():
 
     path = Path(args.file)
     content = path.read_text(encoding="utf-8")
-    normalized = normalize(content.strip()) + "\n"
+    filtered = filter_changelog(content.strip())
+    normalized = normalize(filtered) + "\n"
     path.write_text(normalized, encoding="utf-8")
 
 
diff --git a/tests/test_normalize_changelog.py b/tests/test_normalize_changelog.py
index 9668742..9a892f0 100644
--- a/tests/test_normalize_changelog.py
+++ b/tests/test_normalize_changelog.py
@@ -64,6 +64,24 @@ def test_preserves_heading_text(self):
         result = normalize_mod.normalize(text)
         self.assertIn("## deployed-2026-03-24T1317Z", result)
 
+    def test_filter_removes_noop_dependency_bullet(self):
+        text = "## v1.0\n\n• Added login\n• Update some dependencies (none)\n• Fixed logout"
+        result = normalize_mod.filter_changelog(text)
+        self.assertIn("• Added login", result)
+        self.assertIn("• Fixed logout", result)
+        self.assertNotIn("• Added login\n\n• Fixed logout", result)
+        self.assertNotIn("Update some dependencies (none)", result)
+
+    def test_filter_preserves_named_dependency_bullet(self):
+        text = "## v1.0\n\n• Update some dependencies (firebase, sentry)"
+        result = normalize_mod.filter_changelog(text)
+        self.assertIn("• Update some dependencies (firebase, sentry)", result)
+
+    def test_normalize_does_not_filter_changelog_content(self):
+        text = "## v1.0\n\n• Update some dependencies (none)"
+        result = normalize_mod.normalize(text)
+        self.assertIn("• Update some dependencies (none)  ", result)
+
     def test_idempotent(self):
         text = "## v1.0\n\n• First  \n• Second  \n\n## v2.0\n\n• Third  "
         first = normalize_mod.normalize(text)
@@ -101,6 +119,25 @@ def test_main_normalizes_file_in_place(self):
                 if line.startswith("•"):
                     self.assertTrue(line.endswith("  "))
 
+    def test_main_filters_before_normalizing_file(self):
+        with tempfile.TemporaryDirectory() as tmpdir:
+            path = Path(tmpdir) / "input.md"
+            path.write_text(
+                "## v1.0\n"
+                "• Added login\n"
+                "• Update some dependencies (none)\n"
+                "• Fixed logout\n",
+                encoding="utf-8",
+            )
+
+            with mock.patch.object(sys, "argv", ["prog", str(path)]):
+                normalize_mod.main()
+
+            result = path.read_text(encoding="utf-8")
+            self.assertIn("• Added login  ", result)
+            self.assertIn("• Fixed logout  ", result)
+            self.assertNotIn("Update some dependencies (none)", result)
+
 
 if __name__ == "__main__":
     unittest.main()