Skip to content

Conversation

@karbassi
Copy link
Member

No description provided.

@karbassi karbassi requested a review from Copilot July 25, 2025 04:09
@karbassi karbassi linked an issue Jul 25, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive documentation for upgrading the We All Code Django application from Python 3.11 to Python 3.13, while modernizing the codebase to leverage native Python functions and language features. The documentation also includes the complete removal of previously planned Black-to-Ruff migration specifications.

  • Adds detailed implementation plan with 17 structured tasks for Python modernization
  • Defines comprehensive requirements covering version updates, type annotations, and code modernization
  • Provides technical design document outlining migration strategy and architecture
  • Removes all Black-to-Ruff migration documentation files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.kiro/specs/python-modernization/tasks.md Comprehensive 17-task implementation plan for Python 3.13 upgrade and code modernization
.kiro/specs/python-modernization/requirements.md Detailed requirements document with 6 user stories covering Python version updates and modernization goals
.kiro/specs/python-modernization/design.md Technical design document outlining migration strategy, architecture, and implementation approach
.kiro/specs/black-to-ruff-migration/tasks.md Complete removal of Black-to-Ruff migration task documentation
.kiro/specs/black-to-ruff-migration/requirements.md Complete removal of Black-to-Ruff migration requirements
.kiro/specs/black-to-ruff-migration/design.md Complete removal of Black-to-Ruff migration design documentation
Comments suppressed due to low confidence (1)

.kiro/specs/python-modernization/design.md:23

  • Django 5.2.x does not exist. The latest Django LTS version is 4.2.x, and Django 5.0+ versions exist but Django 5.2 has not been released. Please verify the current Django version and update to reflect the actual version being used.
| Django     | 5.2.x           | 5.2.x          | ✅ Python 3.13 compatible       |

karbassi added 3 commits July 25, 2025 21:13
- Update .python-version to 3.13
- Update pyproject.toml requires-python to >=3.13,<3.14
- Update Dockerfile base image to python:3.13
- Update Ruff target-version to py313
- Remove custom batches() implementation from coderdojochi/util.py
- Use native itertools.batched() for email recipient batching
- Modernize code to leverage Python 3.12+ standard library features

Addresses requirements 3.1 and 6.4 from python-modernization spec
- Add type hints to all 12 function parameters and return type
- Use modern union syntax (|) instead of Union for optional parameters
- Replace typing.List/Dict with built-in list/dict types
- Fix mutable default arguments by using None and proper initialization
- Improve code maintainability and IDE support for type checking

Addresses requirements 2.1, 2.2, 2.3, 2.4 from python-modernization spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to latest version of python

2 participants