-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Description
With our fixtures id3tag raises an exception when addressing Tag#genre
apparently.
1) FormatParser::MP3Parser decodes and estimates duration for a CBR MP3
Failure/Error: value = tag.public_send(k)
NoMethodError:
undefined method `gsub' for nil:NilClass
# /Users/julik/Code/libs/id3tag/lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24.rb:25:in `just_genres'
# /Users/julik/Code/libs/id3tag/lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24.rb:12:in `genres'
# /Users/julik/Code/libs/id3tag/lib/id3tag/frames/v2/genre_frame.rb:23:in `get_genres'
# /Users/julik/Code/libs/id3tag/lib/id3tag/frames/v2/genre_frame.rb:8:in `genres'
I've pushed a branch called id3tag-bug
which demonstrates it. We need to find out why that happens, create a minimal test case and file a PR for https://github.com/krists/id3tag
The rescue nil
clause in the MP3 parser code can then be removed.