fix: atomic sync for delete and backup metadata share

Author: ieow

src/mpcCoreKit.ts

@@ -1350,19 +1350,21 @@ export class Web3AuthMPCCoreKit implements ICoreKit {
   }
 
   private async deleteMetadataShareBackup(factorKey: BN): Promise<void> {
-    await this.tKey.addLocalMetadataTransitions({ input: [{ message: SHARE_DELETED, dateAdded: Date.now() }], privKey: [factorKey] });
-    if (!this.tkey?.manualSync) await this.tkey?.syncLocalMetadataTransitions();
+    await this.atomicSync(async () => {
+      await this.tKey.addLocalMetadataTransitions({ input: [{ message: SHARE_DELETED, dateAdded: Date.now() }], privKey: [factorKey] });
+    });
   }
 
   private async backupMetadataShare(factorKey: BN) {
     const metadataShare = await this.getMetadataShare();
 
-    // Set metadata for factor key backup
-    await this.tKey?.addLocalMetadataTransitions({
-      input: [metadataShare],
-      privKey: [factorKey],
+    await this.atomicSync(async () => {
+      // Set metadata for factor key backup
+      await this.tKey?.addLocalMetadataTransitions({
+        input: [metadataShare],
+        privKey: [factorKey],
+      });
     });
-    if (!this.tkey?.manualSync) await this.tkey?.syncLocalMetadataTransitions();
   }
 
   private async addFactorDescription(args: {

tests/ed25519.spec.ts

@@ -171,6 +171,7 @@ variable.forEach((testVariable) => {
       }
       const exportedSeed = await coreKitInstance._UNSAFE_exportTssEd25519Seed();
 
+      // import tss key into mpc corekit
       const coreKitInstance2 = newCoreKitInstance();
       await coreKitInstance2.init({ handleRedirectResult: false, rehydrate: false });
       const localToken2 = await mockLogin2(importedEmail);
@@ -180,13 +181,13 @@ variable.forEach((testVariable) => {
         idToken: localToken2.idToken,
         importTssKey: exportedSeed.toString("hex"),
       });
+      if (manualSync) {
+        await coreKitInstance2.commitChanges();
+      }
 
       const exportedSeed2 = await coreKitInstance2._UNSAFE_exportTssEd25519Seed();
 
       assert(exportedSeed.toString("hex") === (exportedSeed2.toString("hex")));
     });
-
-
-
   });
 });