Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on card click (PandoProject) #34

Closed
2 tasks done
kquirapas opened this issue Aug 20, 2022 · 13 comments · May be fixed by #35
Closed
2 tasks done

404 on card click (PandoProject) #34

kquirapas opened this issue Aug 20, 2022 · 13 comments · May be fixed by #35
Assignees
Labels
bug Issue Label for Bug Reports chore Issue/Pull Request Label for Housekeeping in progress Issue/Pull Request Label for In Progress Status
Milestone

Comments

@kquirapas
Copy link
Contributor

🤔 Not Existing Bug?

  • Yes, I'm sure that this is a bug!

👀 Current Behavior

It's 404 on card click

🎯 Expected Behavior

Should redirect to entity site

📋 Steps To Reproduce

No response

📜 Code of Conduct

@kquirapas kquirapas added bug Issue Label for Bug Reports pending Issue/Pull Request Label for Pending Status labels Aug 20, 2022
@litchdoteth
Copy link
Contributor

litchdoteth commented Aug 20, 2022

@kquirapas maybe its because of the json file. PANDOPROJECT doesn't have any website indicated on the file

@litchdoteth
Copy link
Contributor

litchdoteth commented Aug 20, 2022

same goes to Royal Labs

@kquirapas
Copy link
Contributor Author

kquirapas commented Aug 20, 2022

lets piggyback on next milestone @warengonzaga @itsnalla

@litchdoteth
Copy link
Contributor

litchdoteth commented Aug 20, 2022

we need to standardize the form so that we can add their respective links. The required URL is the Project Website, if they don't have any maybe they can add their Twitter or Facebook. Additional and optional URL's are their socials, community, decks/whitepaper etc.

@jnebab
Copy link
Contributor

jnebab commented Aug 20, 2022

I'll fix this on my next PR. i'll include all social links on a larger preview onCardClick so viewers can have other options if other links dont work. and I agree wth @itsnalla, we cant allow no links added during signup. whats the point of adding a project to the directory if no links to contact you. maybe, at least require website url and 1 social media link during signup

@warengonzaga
Copy link
Member

Please tag this issue on any PR you made folks. 🤝
Thank you for reporting!

@warengonzaga warengonzaga added this to the v1.2.0 milestone Aug 20, 2022
@warengonzaga warengonzaga added in progress Issue/Pull Request Label for In Progress Status and removed pending Issue/Pull Request Label for Pending Status labels Aug 20, 2022
@warengonzaga warengonzaga assigned jnebab and unassigned warengonzaga Aug 20, 2022
@kquirapas
Copy link
Contributor Author

@itsnalla Kindly edit your comments (just like I did) to make it full english so our international contributors can easily contribute. Thank you!

@warengonzaga warengonzaga added the chore Issue/Pull Request Label for Housekeeping label Aug 20, 2022
@warengonzaga warengonzaga linked a pull request Aug 20, 2022 that will close this issue
@warengonzaga warengonzaga pinned this issue Aug 20, 2022
@litchdoteth
Copy link
Contributor

@itsnalla Kindly edit your comments (just like I did) to make it full english so our international contributors can easily contribute. Thank you!

edited thanks for correcting bro.

@warengonzaga warengonzaga changed the title PANDOPROJECT: 404 on card click 404 on card click (PandoProject) Aug 20, 2022
@warengonzaga
Copy link
Member

Let's prioritize the fix for this thanks!

@kquirapas
Copy link
Contributor Author

kquirapas commented Aug 20, 2022

@jnebab @itsnalla fixing this on the api. I will either remove or change both RoyalLabs and PandoProject links

@kquirapas
Copy link
Contributor Author

Resolved. Web3Philippines/directory-api#5

@kquirapas
Copy link
Contributor Author

Will close on merge to main

@warengonzaga warengonzaga assigned kquirapas and unassigned jnebab Aug 20, 2022
@warengonzaga
Copy link
Member

Closing this now as the issue fixed on the directory-api repo.

@warengonzaga warengonzaga unpinned this issue Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue Label for Bug Reports chore Issue/Pull Request Label for Housekeeping in progress Issue/Pull Request Label for In Progress Status
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants