-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 on card click (PandoProject) #34
Comments
@kquirapas maybe its because of the json file. PANDOPROJECT doesn't have any website indicated on the file |
same goes to Royal Labs |
lets piggyback on next milestone @warengonzaga @itsnalla |
we need to standardize the form so that we can add their respective links. The required URL is the Project Website, if they don't have any maybe they can add their Twitter or Facebook. Additional and optional URL's are their socials, community, decks/whitepaper etc. |
I'll fix this on my next PR. i'll include all social links on a larger preview onCardClick so viewers can have other options if other links dont work. and I agree wth @itsnalla, we cant allow no links added during signup. whats the point of adding a project to the directory if no links to contact you. maybe, at least require website url and 1 social media link during signup |
Please tag this issue on any PR you made folks. 🤝 |
@itsnalla Kindly edit your comments (just like I did) to make it full english so our international contributors can easily contribute. Thank you! |
edited thanks for correcting bro. |
Let's prioritize the fix for this thanks! |
@jnebab @itsnalla fixing this on the api. I will either remove or change both RoyalLabs and PandoProject links |
Resolved. Web3Philippines/directory-api#5 |
Will close on merge to main |
Closing this now as the issue fixed on the directory-api repo. |
🤔 Not Existing Bug?
👀 Current Behavior
It's 404 on card click
🎯 Expected Behavior
Should redirect to entity site
📋 Steps To Reproduce
No response
📜 Code of Conduct
The text was updated successfully, but these errors were encountered: