Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit tags to 3 and up to 5 max only #47

Closed
warengonzaga opened this issue Aug 21, 2022 Discussed in #30 · 9 comments · May be fixed by #35
Closed

limit tags to 3 and up to 5 max only #47

warengonzaga opened this issue Aug 21, 2022 Discussed in #30 · 9 comments · May be fixed by #35
Labels
good first issue Issue Label for First Time Contributors hacktoberfest Hacktoberfest Related Pull Request or Issue help wanted Issue Label for Asking Help todo Issue Label for Todo Status tweak Issue/Pull Request for Tweaks
Milestone

Comments

@warengonzaga
Copy link
Member

Discussed in #30

We've decided to limit the tags to 3 and max only 5.

cc: @itsnalla @jnebab @kquirapas

@warengonzaga warengonzaga added good first issue Issue Label for First Time Contributors help wanted Issue Label for Asking Help todo Issue Label for Todo Status tweak Issue/Pull Request for Tweaks labels Aug 21, 2022
@warengonzaga warengonzaga added this to the v1.2.0 📦 milestone Aug 21, 2022
@warengonzaga warengonzaga pinned this issue Aug 21, 2022
@kquirapas
Copy link
Contributor

@warengonzaga @itsnalla @jnebab

Lets finalize tags on the discussion below then we can start working on this issue

#30

@jnebab
Copy link
Contributor

jnebab commented Aug 21, 2022

can we provide them a set of tags they can choose from instead of letting them come up with the tags themselves during signup?

@kquirapas
Copy link
Contributor

We should finalize tags in #30 today @warengonzaga @jnebab @itsnalla

@kquirapas
Copy link
Contributor

@itsnalla check latest comment here #30

and update API JSON

@litchdoteth
Copy link
Contributor

@itsnalla check latest comment here #30

and update API JSON
updating atm, will create a PR asap

@warengonzaga warengonzaga linked a pull request Aug 29, 2022 that will close this issue
@warengonzaga warengonzaga added hacktoberfest Hacktoberfest Related Pull Request or Issue and removed in progress Issue/Pull Request Label for In Progress Status labels Sep 26, 2022
@warengonzaga
Copy link
Member Author

@kquirapas @itsnalla is this all good?

@litchdoteth
Copy link
Contributor

@kquirapas @itsnalla is this all good?

all good brother.

@warengonzaga
Copy link
Member Author

I mean all the tags are limited to max 5? @itsnalla

@warengonzaga warengonzaga unpinned this issue Oct 11, 2022
@warengonzaga
Copy link
Member Author

I can close this now as all the items in #35 are limited to 5 max tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue Label for First Time Contributors hacktoberfest Hacktoberfest Related Pull Request or Issue help wanted Issue Label for Asking Help todo Issue Label for Todo Status tweak Issue/Pull Request for Tweaks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants