[NFC] Properly mark ConstantFieldPropagation as requiring closed-world (#8007)

The fuzzer only had one variant of the pass marked that way. Also, we
were missing the explicit error.

Author: kripken

scripts/fuzz_opt.py

@@ -2370,6 +2370,7 @@ def write_commands(commands, filename):
                          ("--remove-unused-types",),
                          ("--abstract-type-refining",),
                          ("--cfp",),
+                         ("--cfp-reftest",),
                          ("--gsi",),
                          ("--type-ssa",),
                          ("--type-merging",)}

src/passes/ConstantFieldPropagation.cpp

@@ -549,6 +549,10 @@ struct ConstantFieldPropagation : public Pass {
       return;
     }
 
+    if (!getPassOptions().closedWorld) {
+      Fatal() << "CFP requires --closed-world";
+    }
+
     // Find and analyze all writes inside each function.
     PCVFunctionStructValuesMap functionNewInfos(*module),
       functionSetInfos(*module);

test/lit/passes/cfp-desc.wast

@@ -1,6 +1,6 @@
 ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
 
-;; RUN: foreach %s %t wasm-opt --cfp -all -S -o - | filecheck %s
+;; RUN: foreach %s %t wasm-opt --cfp --closed-world -all -S -o - | filecheck %s
 
 (module
   (rec

test/lit/passes/cfp-reftest-desc.wast

@@ -1,6 +1,6 @@
 ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
 
-;; RUN: foreach %s %t wasm-opt --cfp-reftest -all -S -o - | filecheck %s
+;; RUN: foreach %s %t wasm-opt --cfp-reftest --closed-world -all -S -o - | filecheck %s
 
 ;; When a ref.get_desc can only read from two types, and those types have a
 ;; constant field, we can select between those two values using a ref.test.

test/lit/passes/cfp-reftest.wast

@@ -1,6 +1,6 @@
 ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
 
-;; RUN: foreach %s %t wasm-opt --cfp-reftest -all -S -o - | filecheck %s
+;; RUN: foreach %s %t wasm-opt --cfp-reftest --closed-world -all -S -o - | filecheck %s
 
 ;; When a struct.get can only read from two types, and those types have a
 ;; constant field, we can select between those two values using a ref.test.

test/lit/passes/cfp-rmw.wast

@@ -1,6 +1,6 @@
 ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
 
-;; RUN: foreach %s %t wasm-opt --cfp -all -S -o - | filecheck %s
+;; RUN: foreach %s %t wasm-opt --cfp --closed-world -all -S -o - | filecheck %s
 
 ;; RMW ops are generally writes that inhibit optimization.
 (module

test/lit/passes/cfp.wast

@@ -1,6 +1,6 @@
 ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
 
-;; RUN: foreach %s %t wasm-opt --remove-unused-names --cfp -all -S -o - | filecheck %s
+;; RUN: foreach %s %t wasm-opt --remove-unused-names --cfp --closed-world -all -S -o - | filecheck %s
 
 ;; (remove-unused-names is added to test fallthrough values without a block
 ;; name getting in the way)