Issue with features section: mutable-globals, nontrapping-float-to-int, bulk-memory, sign-ext, bulk-memory-opt in wasm2js and wasm-dis

[CreatorEdition]

When converting a WebAssembly module using wasm2js, I encountered an error related to the features section of the module. The module includes advanced WebAssembly features such as mutable-globals, bulk-memory, and sign-ext. Despite attempts to optimize or strip these features using wasm-opt, the error persists.

The error message is as follows:

;; features section: mutable-globals, nontrapping-float-to-int, bulk-memory, sign-ext, bulk-memory-opt Fatal: error in validating wasm2js output

;; features section: mutable-globals, nontrapping-float-to-int, bulk-memory, sign-ext, bulk-memory-opt in after use wasm-dis in file

Steps to Reproduce

1. Use the following WebAssembly file (or a similar file with advanced features):

2. Run the following commands:```bash
   wasm-opt input.wasm --strip-debug --strip-producers --disable-mutable-globals --disable-bulk-memory -o optimized.wasm -O2
   wasm2js optimized.wasm -o output.js

3.Observe the error related to the features section.

Actual Behavior

The conversion process fails with a validation error, even after attempting to strip or disable advanced WebAssembly features using wasm-opt.

Environment

Tool version: Binaryen 121
Command line used: wasm2js, wasm-opt
OS: win11

Additional Context

I have attempted the following solutions:

Stripping debug and producer sections using wasm-opt.
Disabling specific features like mutable-globals and bulk-memory during optimization.
Re-generating the WebAssembly file with minimal features.
The issue persists even when using the latest version of Binaryen.

Suggested Improvement

Enhance wasm2js to either skip unsupported features or convert as much as possible while issuing warnings.
Provide better documentation or guidance for handling advanced WebAssembly features in wasm2js.

[kripken]

I have attempted the following solutions: Re-generating the WebAssembly file with minimal features.

That should work. If it does not then something else is going on rather than features. Make sure that you are emitting a wasm file without those features.

In general, wasm2js is meant to support very old browsers and runtimes, places without wasm. Those places will not benefit from newer wasm features like sign-ext, so wasm2js does not support them.

Note that there are some lowering passes you can run before wasm2js, that can help in some cases: --llvm-memory-copy-fill-lowering, --llvm-nontrapping-fptoint-lowering, --signext-lowering, but they have limitations. It is best to just not emit the features, if you will be running wasm2js.

[guest271314]

What executable has that --llvm-nontrapping-fptoint-lowering?

../binaryen/bin/wasm-opt module.wasm --llvm-nontrapping-fptoint-lowering -o optimized-module.wasm
Unknown option '--llvm-nontrapping-fptoint-lowering'

I might be running in to that with AssemblyScript to wasm2js that hangs.

[kripken]

--llvm-nontrapping-fptoint-lowering is in wasm-opt from the very latest version of binaryen. Make sure you are not using an earlier version.

[guest271314]

I get Fatal: error validating input WASM compiled with AssemblyScript.

[guest271314]

This worked for Rust source code, not for AssemblyScript source code

../binaryen/bin/wasm-opt module.wasm --llvm-memory-copy-fill-lowering  --llvm-nontrapping-fptoint-lowering --signext-lowering --enable-mutable-globals --enable-bulk-memory  --signext-lowering  -o module-wasm-opt.wasm
[wasm-validator error in function 130] unexpected false: all used features should be allowed, on 
(i32.trunc_sat_f64_s
 (call $117
  (local.get $5)
  (i32.const 0)
 )
)
[wasm-validator error in function 130] unexpected false: all used features should be allowed, on 
(i32.trunc_sat_f64_s
 (call $117
  (local.get $5)
  (i32.const 0)
 )
)
[wasm-validator error in function 130] unexpected false: all used features should be allowed, on 
(i32.trunc_sat_f64_s
 (call $117
  (local.get $5)
  (i32.const 0)
 )
)
[wasm-validator error in function 130] unexpected false: all used features should be allowed, on 
(i32.trunc_sat_f64_s
 (call $117
  (local.get $5)
  (i32.const 0)
 )
)
Fatal: error validating input