Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwabt.js builds are broken with Emscripten upstream/tot #1421

Open
dcodeIO opened this issue May 12, 2020 · 3 comments
Open

libwabt.js builds are broken with Emscripten upstream/tot #1421

dcodeIO opened this issue May 12, 2020 · 3 comments

Comments

@dcodeIO
Copy link
Contributor

dcodeIO commented May 12, 2020

Noticed this here while attempting to update the wabt.js buildbot to GitHub Actions and decided to test with all of fastcomp, upstream and tot because why not.

Tracked this down so far to Module._malloc for example trying to call into Module['asm']['ya'], which does not exist.

@binji
Copy link
Member

binji commented May 13, 2020

I think I saw a similar bug to this before, and it was due to a bug in wasm2js that was fixed in emsdk-latest. In fact, I recently updated libwabt.js using emscripten version 1.39.13, and it seems to work. Strange that it would be failing on tot. Maybe @sbc100 or @kripken knows?

@kripken
Copy link
Member

kripken commented May 13, 2020

Not aware of any bugs there. It sounds like the import/export minification is wrong somehow? Weird.

Any chance it's using a js from one build with a wasm from another?

@dcodeIO
Copy link
Contributor Author

dcodeIO commented May 13, 2020

Might also have something to do with subtle changes since the MODULARIZE rework, but haven't yet been able to pinpoint. Another thing I noticed was that if I replace Module._malloc with just _malloc in the JS wrapper, the malloc issue goes away but others remain. Interestingly, switching all Module._wabt_something to Module['_wabt_something'] doesn't help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants