You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@aardappel mentioned that it would be nice to have a checklist when adding a new instruction; there are a lot of places that you need to change, and it's easy to miss some.
The compiler will catch a number of them, since adding a new enum to the opcodes list will create a warning, but there are some that only get flushed out with a new test.
It may be instructive to look at the distinction between the bulk-memory-operation change here, and the one that landed afterward here.
The text was updated successfully, but these errors were encountered:
On Oct 16, 2018, at 8:08 AM, Ben Smith ***@***.***> wrote:
@aardappel mentioned that it would be nice to have a checklist when adding a new instruction; there are a lot of places that you need to change, and it's easy to miss some.
The compiler will catch a number of them, since adding a new enum to the opcodes list will create a warning, but there are some that only get flushed out with a new test.
It may be instructive to look at the distinction between the bulk-memory-operation change here, and the one that landed afterward here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
@aardappel mentioned that it would be nice to have a checklist when adding a new instruction; there are a lot of places that you need to change, and it's easy to miss some.
The compiler will catch a number of them, since adding a new enum to the opcodes list will create a warning, but there are some that only get flushed out with a new test.
It may be instructive to look at the distinction between the bulk-memory-operation change here, and the one that landed afterward here.
The text was updated successfully, but these errors were encountered: