Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist for new instructions #932

Open
binji opened this issue Oct 15, 2018 · 1 comment
Open

Add checklist for new instructions #932

binji opened this issue Oct 15, 2018 · 1 comment

Comments

@binji
Copy link
Member

binji commented Oct 15, 2018

@aardappel mentioned that it would be nice to have a checklist when adding a new instruction; there are a lot of places that you need to change, and it's easy to miss some.

The compiler will catch a number of them, since adding a new enum to the opcodes list will create a warning, but there are some that only get flushed out with a new test.

It may be instructive to look at the distinction between the bulk-memory-operation change here, and the one that landed afterward here.

@fgmccabe
Copy link
Contributor

fgmccabe commented Oct 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants