Skip to content

Commit 16d2374

Browse files
committed
update es5 vs es5 config
1 parent cb66bc1 commit 16d2374

4 files changed

Lines changed: 22173 additions & 21420 deletions

File tree

‎JetStreamDriver.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2284,7 +2284,7 @@ let BENCHMARKS = [
22842284
BUNDLE: "./babylonjs/dist/bundle.es5.min.js",
22852285
},
22862286
arguments: {
2287-
expectedCacheCommentCount: 21238,
2287+
expectedCacheCommentCount: 23990,
22882288
},
22892289
tags: ["startup", "class", "es5", "babylonjs"],
22902290
iterations: 10,
@@ -2299,7 +2299,7 @@ let BENCHMARKS = [
22992299
BUNDLE: "./babylonjs/dist/bundle.es6.min.js",
23002300
},
23012301
arguments: {
2302-
expectedCacheCommentCount: 21230,
2302+
expectedCacheCommentCount: 21222,
23032303
},
23042304
tags: ["Default", "startup", "class", "es6", "babylonjs"],
23052305
iterations: 10,

‎babylonjs/dist/bundle.es5.min.js‎

Lines changed: 22160 additions & 21415 deletions
Large diffs are not rendered by default.

‎babylonjs/dist/bundle.es5.min.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎babylonjs/webpack.config.mjs‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ import CacheBusterPlugin from "../startup-helper/BabelCacheBuster.mjs";
88
const __dirname = path.dirname(fileURLToPath(import.meta.url));
99

1010
function createConfig({ es6, filename, minify }) {
11+
let babelPlugins = []
12+
let babelTargets = { chrome: "100" }
13+
if (!es6) {
14+
// enable loose class definitions for es5 (e.g. with prototype assignments)
15+
babelPlugins = [["@babel/plugin-transform-classes", { loose: true }],];
16+
// Use a reasonably ok pre-es6 classes browser.
17+
babelTargets = { chrome: "40" };
18+
}
1119
return {
1220
entry: "./src/babylon-js-benchmark.mjs",
1321
mode: "production",
@@ -33,11 +41,11 @@ function createConfig({ es6, filename, minify }) {
3341
presets: [
3442
[
3543
"@babel/preset-env",
36-
{ targets: es6 ? "defaults" : "ie 11" },
44+
{ targets: babelTargets},
3745
],
3846
],
3947
plugins: [
40-
CacheBusterPlugin,
48+
CacheBusterPlugin, ...babel_plugins
4149
],
4250
},
4351
},

0 commit comments

Comments
 (0)