Skip to content

Commit 311a014

Browse files
committed
address comments
1 parent b860247 commit 311a014

8 files changed

Lines changed: 6 additions & 11 deletions

File tree

‎wasm/dotnet/build-aot/wwwroot/_framework/dotnet.js‎

100644100755
Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wasm/dotnet/build-aot/wwwroot/_framework/dotnet.native.js.symbols‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
85:dotnet_BenchTask__RunBatchd__7_MoveNext
8787
86:ut_dotnet_BenchTask__RunBatchd__7_MoveNext
8888
87:dotnet_Interop_RunIteration_int_int_int_int
89-
88:dotnet_Interop___Wrapper_RunIteration_1052663206_System_Runtime_InteropServices_JavaScript_JSMarshalerArgument_
89+
88:dotnet_Interop___Wrapper_RunIteration_188686094_System_Runtime_InteropServices_JavaScript_JSMarshalerArgument_
9090
89:dotnet_Interop__cctor
9191
90:dotnet_Sample_ExceptionsTask__ctor
9292
91:dotnet_Sample_JsonTask__ctor
0 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.

‎wasm/dotnet/build-interp/wwwroot/_framework/dotnet.js‎

100644100755
Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 Bytes
Binary file not shown.

‎wasm/dotnet/build.log‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Built on 2026-01-15T13:57:14Z\n
1+
Built on 2026-01-15T14:54:21Z\n
22
Toolchain versions
33
dotnet 9.0.305
44
wasm-opt version 122 (version_122-92-g7508e81f0)

‎wasm/dotnet/build.sh‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#! /bin/sh
1+
#! /bin/bash
22

33
# Expects to have .NET SDK 9.0.3xx with `wasm-tools` installed.
44
# Installation options:
@@ -25,19 +25,16 @@ for version in "interp" "aot"; do
2525
echo "Building $version..." | tee -a "$BUILD_LOG"
2626

2727
DOTNET_ARGS=""
28-
if [ "$version" = "aot" ]; then
29-
DOTNET_ARGS="-p:RunAOTCompilation=true"
28+
if [ "$version" == "aot" ]; then
29+
DOTNET_ARGS+=" -p:RunAOTCompilation=true"
3030
fi
3131
# Use deterministic builds and don't embed build directory paths to avoid spurious binary updates.
3232
dotnet publish -o ./build-$version ./src/dotnet/dotnet.csproj -p:Deterministic=true -p:DeterministicSourcePaths=true $DOTNET_ARGS
3333

34-
# Workaround for `jsc` CLI
35-
printf '%s\n' 'import.meta.url ??= "";' | cat - ./src/dotnet/bin/Release/net9.0/wwwroot/_framework/dotnet.js > temp.js
3634
# Silence warning on ArrayBuffer instantiation, which we intentionally use
3735
# to keep the workload consistent between browsers and shells (the latter
3836
# don't always support streaming compilation.)
39-
perl -pi -e "s|\Q&&w('WebAssembly resource does not have the expected content type \"application/wasm\", so falling back to slower ArrayBuffer instantiation.')\E||g" temp.js
40-
mv temp.js ./build-$version/wwwroot/_framework/dotnet.js
37+
perl -pi -e "s|\Q&&w('WebAssembly resource does not have the expected content type \"application/wasm\", so falling back to slower ArrayBuffer instantiation.')\E||g" ./build-$version/wwwroot/_framework/dotnet.js
4138

4239
echo "Copying symbol maps..." | tee -a "$BUILD_LOG"
4340
cp ./src/dotnet/obj/Release/net9.0/wasm/for-publish/dotnet.native.js.symbols ./build-$version/wwwroot/_framework/

0 commit comments

Comments
 (0)