Skip to content

Commit c947f73

Browse files
committed
address comments
1 parent 78eea34 commit c947f73

File tree

5 files changed

+6
-13
lines changed

5 files changed

+6
-13
lines changed

JetStreamDriver.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2147,7 +2147,7 @@ let BENCHMARKS = [
21472147
new WasmEMCCBenchmark({
21482148
name: "sqlite3-wasm",
21492149
files: [
2150-
"./polyfills/fast-text-encoding-1.0.3/text.js",
2150+
"./polyfills/fast-text-encoding/1.0.3/text.js",
21512151
"./sqlite3/benchmark.js",
21522152
"./sqlite3/build/jswasm/speedtest1.js",
21532153
],
@@ -2477,7 +2477,7 @@ let BENCHMARKS = [
24772477
new WasmEMCCBenchmark({
24782478
name: "8bitbench-wasm",
24792479
files: [
2480-
"./polyfills/fast-text-encoding-1.0.3/text.js",
2480+
"./polyfills/fast-text-encoding/1.0.3/text.js",
24812481
"./8bitbench/build/rust/pkg/emu_bench.js",
24822482
"./8bitbench/benchmark.js",
24832483
],

polyfills/README

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Polyfills shared across different workloads, for browser APIs that are not available in JavaScript engine shells, e.g., `TextDecoder`.
2+
To make performance between browser and shell measurements not too dissimilar, these shouldn't account for a major part of the runtime (e.g., ideally only be used during initialization, outside of the main measurement loop).
3+
Also, please also add a link to the original sources and licensing information in each subdirectory.
File renamed without changes.

polyfills/README.md renamed to polyfills/fast-text-encoding/LICENSE

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,3 @@
1-
Polyfills shared across different workloads, for browser APIs that are not available in JavaScript engine shells, e.g., `TextDecoder`.
2-
To make performance between browser and shell measurements not too dissimilar, these shouldn't account for a major part of the runtime (e.g., ideally only be used during initialization, outside of the main measurement loop).
3-
4-
# Sources and Licenses
5-
6-
## fast-text-encoding
7-
8-
https://github.com/samthor/fast-text-encoding
9-
10-
```
111
Apache License
122
Version 2.0, January 2004
133
http://www.apache.org/licenses/
@@ -209,4 +199,3 @@ https://github.com/samthor/fast-text-encoding
209199
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
210200
See the License for the specific language governing permissions and
211201
limitations under the License.
212-
```
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
See https://github.com/samthor/fast-text-encoding.

0 commit comments

Comments
 (0)