Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue TodoMVC source maps include full path of author's machine #385

Open
lpardosixtosMs opened this issue Feb 29, 2024 · 3 comments · Fixed by #386
Open

Vue TodoMVC source maps include full path of author's machine #385

lpardosixtosMs opened this issue Feb 29, 2024 · 3 comments · Fixed by #386
Labels
trivial change A change that doesn't affect benchmark results

Comments

@lpardosixtosMs
Copy link
Contributor

The source maps for Vue TodoMVC are using the full path instead of the relative path, causing fake file changes every time a new person builds it. E.g:

"\n\nimport exportComponent from \"/Users/thorstenk/Desktop/FlashDesignory/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n

to

"\n\nimport exportComponent from \"/home/issackjohn/issack/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n

in #376.

@rniwa
Copy link
Member

rniwa commented Feb 29, 2024

Oh, can we fix this before 3.0 release?

@julienw
Copy link
Contributor

julienw commented Mar 4, 2024

One can see the webpack config used by vue like this:

./node_modules/.bin/vue-cli-service inspect --mode production 2>&1| less

Here we clearly see that the absolute directory is used everywhere. I'm not sure which of these impacts the source map generation.
Clearly in my other non-vue webpack-based project this isn't happening.

@julienw julienw reopened this Mar 4, 2024
@rniwa rniwa removed the v3-blocker label Mar 4, 2024
@rniwa
Copy link
Member

rniwa commented Mar 4, 2024

Removing v3-blocker keyword since this doesn't need to block the release of Speedometer 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants