fix(root): 리뷰 문서 커밋 경로 검증 명확화

Author: wantkdd

.github/scripts/review_publishing.py

@@ -142,8 +142,13 @@ def pr_review_doc_path(pr_number: int) -> str:
     return f"{DOC_ROOT}/PR-{pr_number}.md"
 
 
+def _pr_number_from_review_doc_path(path: str) -> int | None:
+    match = re.fullmatch(r"docs/pr-reviews/PR-([1-9][0-9]*)\.md", path.strip())
+    return int(match.group(1)) if match else None
+
+
 def is_pr_review_doc_path(path: str) -> bool:
-    return bool(re.fullmatch(r"docs/pr-reviews/PR-[1-9][0-9]*\.md", path.strip()))
+    return _pr_number_from_review_doc_path(path) is not None
 
 
 def parse_right_side_lines(files: Sequence[Mapping[str, Any]]) -> dict[str, set[int]]:
@@ -1021,8 +1026,10 @@ def generated_doc_only_parent_sha(
         or not isinstance(parents[0], Mapping)
     ):
         return None
-    document_pr_number = int(Path(paths[0]).stem.removeprefix("PR-"))
-    if message != _doc_commit_message(document_pr_number):
+    document_pr_number = _pr_number_from_review_doc_path(paths[0])
+    if document_pr_number is None or message != _doc_commit_message(
+        document_pr_number
+    ):
         return None
     return _string(parents[0].get("sha")) or None
 

.github/scripts/test_review_publishing.py

@@ -682,6 +682,25 @@ def test_rejects_mismatched_pr_number_in_generated_message(self):
             )
         )
 
+    def test_rejects_invalid_review_doc_number_without_raising(self):
+        github = FakeGitHub(
+            responses=[
+                {
+                    "commit": {
+                        "message": "docs(docs): PR-invalid 리뷰 판단 근거 기록"
+                    },
+                    "files": [{"filename": "docs/pr-reviews/PR-invalid.md"}],
+                    "parents": [{"sha": "parent-sha"}],
+                }
+            ]
+        )
+
+        self.assertIsNone(
+            rp.generated_doc_only_parent_sha(
+                "api", "token", "repo", {"head": {"sha": "abc"}}, github
+            )
+        )
+
     def test_recognizes_pr_review_document_path(self):
         self.assertTrue(rp.is_pr_review_doc_path("docs/pr-reviews/PR-1.md"))
         self.assertFalse(rp.is_pr_review_doc_path("docs/pr-reviews/README.md"))