Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Links text lack context #226

Open
alexstine opened this issue Apr 11, 2023 · 4 comments
Open

Accessibility: Links text lack context #226

alexstine opened this issue Apr 11, 2023 · 4 comments

Comments

@alexstine
Copy link

Please see the related thread in Slack: https://wordpress.slack.com/archives/C02QB8GMM/p1681178996567369

Who maintains this page?
https://wordpress.org/five-for-the-future/
There is a need for slightly more descriptive link text. Looks like this is coming from the block editor. I placed quotes around the current links and what my suggestion would be for new links.
Ready to get started? Contribute as an "individual" or as an "organization".
Ready to get started?
"Contribute as an individual"
"Contribute as an organization"
Makes more sense to arrange these as a list (ul) maybe?
I am an individual interested in participating in WordPress
"Get Involved"
I am part of an organization interested in participating in WordPress
"Get Started"
I think these links can go away and the sentence can become the link?

There was concern about these links being too ugly but I do not think Gutenberg supports aria-label at this point. Could use some design feedback.

@naokomc
Copy link

naokomc commented Jul 31, 2023

@alexstine I have access to the dashboard, so I tried editing the section under H2 heading "How to Participate":

<!-- wp:columns {"className":"is-style-wporg-parallelogram"} -->
<div class="wp-block-columns is-style-wporg-parallelogram"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="https://wordpress.org/five-for-the-future/for-individuals/">Participate as an <strong>individual</strong></a></div>
<!-- /wp:button --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="https://wordpress.org/five-for-the-future/for-organizations/">Participate as an <strong>organization</strong></a></div>
<!-- /wp:button --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->

Test page link: https://wordpress.org/five-for-the-future/?page_id=15067&preview=1&_ppp=61386f1688

The visual representation on this page looks different from the actual modification because of the CSS rules applied only to the front page. Once the change is added to the front page, the colored background will cover behind the buttons.

Screenshot of the example code

If this sounds good, I can edit the front page.

The "Ready to get started?" part at the beginning of the page requires CSS change, so I'll leave it to a designer/developer.

@alexstine
Copy link
Author

@naokomc

If this sounds good, I can edit the front page.

Looks good, please proceed with edits.

Thanks.

@naokomc
Copy link

naokomc commented Aug 1, 2023

Thanks for reviewing, @alexstine. I published the change to the "How to Participate" section: https://wordpress.org/five-for-the-future/

I have access to the Block Editor but I'm not the best person to suggest improvement to the CSS. Would be nice to have help there.

There is a need for slightly more descriptive link text. Looks like this is coming from the block editor. I placed quotes around the current links and what my suggestion would be for new links.
Ready to get started? Contribute as an "individual" or as an "organization".
Ready to get started?
"Contribute as an individual"
"Contribute as an organization"
Makes more sense to arrange these as a list (ul) maybe?

@naokomc naokomc removed their assignment Aug 1, 2023
@alexstine
Copy link
Author

@naokomc The UL would work fine for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants