Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Theme: Hide middot on pledge page when content is wrapped. #313

Open
StevenDufresne opened this issue Sep 13, 2024 · 3 comments
Open

Comments

@StevenDufresne
Copy link
Contributor

When viewing a pledge page on mobile, or tablet, there middot is visible but isn't separating content.

Screenshots

URL: https://wordpress.org/five-for-the-future/pledge/whodunit/

Screenshot 2024-09-13 at 9 46 04 AM Screenshot 2024-09-13 at 9 44 20 AM
@StevenDufresne
Copy link
Contributor Author

Related, is "This organization contributes 5% of their resources to the WordPress project." really valuable if it shows up on every listing?

It seems like that byline should be specific to the company but that's a generic statement about all pledges.

@ryelle
Copy link
Contributor

ryelle commented Sep 13, 2024

Since the URL is a dynamic length, we don't know when it wraps, so we can't hide this dynamically. Maybe a different content layout would be better?

Related, is "This organization contributes 5% of their resources to the WordPress project." really valuable if it shows up on every listing?

+1 — I'm sure we want this on the page for content/SEO reasons, but maybe it could be in the main content section instead?

Screenshot 2024-09-13 at 11 03 55 AM

@fcoveram
Copy link

I'm drawn to replacing the dot with a similar spacing gap to reinforce the content difference. The SEO reason sounds solid to keep the sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To do
Development

No branches or pull requests

3 participants