Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naively higher rate limit for requests with openverse.org referrer #3484

Closed
sarayourfriend opened this issue Dec 7, 2023 · 0 comments · Fixed by #3486
Closed

Add naively higher rate limit for requests with openverse.org referrer #3484

sarayourfriend opened this issue Dec 7, 2023 · 0 comments · Fixed by #3486
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Problem

We've had to turn off rate limiting due to accidentally rate limiting users in school settings that share a single IP.

Description

These are all from the Openverse.org website. As a temporary holdover until we can create a better solution, we'll just use a separate rate limit class when the referrer header is Openverse.org.

Additional context

We know this is imperfect but there's no good way to solve this right now that doesn't include just leaving rate limiting off entirely for an indefinite period of time. This is a stop gap solution we sould remove once something like #3473 is implemented.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Dec 7, 2023
@sarayourfriend sarayourfriend self-assigned this Dec 7, 2023
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Dec 7, 2023
@AetherUnbound AetherUnbound moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Dec 7, 2023
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Dec 7, 2023
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant