Enhance unit tests for WP_Theme_JSON by adding descriptive messages to assertions. This improves clarity on expected outcomes for lightbox settings and appearance tools, ensuring better maintainability and understanding of test intentions.

Author: ramonjd

tests/phpunit/tests/theme/wpThemeJson.php

@@ -6644,8 +6644,8 @@ public function test_sanitize_preserves_boolean_values_when_schema_expects_boole
 		);
 
 		$settings = $theme_json->get_settings();
-		$this->assertTrue( $settings['lightbox']['enabled'] );
-		$this->assertFalse( $settings['lightbox']['allowEditing'] );
+		$this->assertTrue( $settings['lightbox']['enabled'], 'Enabled should be true' );
+		$this->assertFalse( $settings['lightbox']['allowEditing'], 'Allow editing should be false' );
 	}
 
 	/**
@@ -6668,8 +6668,8 @@ public function test_sanitize_removes_non_boolean_values_when_schema_expects_boo
 		);
 
 		$settings = $theme_json->get_settings();
-		$this->assertArrayNotHasKey( 'enabled', $settings['lightbox'] ?? array() );
-		$this->assertArrayNotHasKey( 'allowEditing', $settings['lightbox'] ?? array() );
+		$this->assertArrayNotHasKey( 'enabled', $settings['lightbox'] ?? array(), 'Enabled should be removed' );
+		$this->assertArrayNotHasKey( 'allowEditing', $settings['lightbox'] ?? array(), 'Allow editing should be removed' );
 	}
 
 	/**
@@ -6696,8 +6696,8 @@ public function test_sanitize_preserves_boolean_values_in_block_settings() {
 		);
 
 		$settings = $theme_json->get_settings();
-		$this->assertTrue( $settings['blocks']['core/image']['lightbox']['enabled'] );
-		$this->assertFalse( $settings['blocks']['core/image']['lightbox']['allowEditing'] );
+		$this->assertTrue( $settings['blocks']['core/image']['lightbox']['enabled'], 'Enabled should be true' );
+		$this->assertFalse( $settings['blocks']['core/image']['lightbox']['allowEditing'], 'Allow editing should be false' );
 	}
 
 	/**
@@ -6725,8 +6725,8 @@ public function test_sanitize_removes_non_boolean_values_in_block_settings() {
 
 		$settings = $theme_json->get_settings();
 		$lightbox = $settings['blocks']['core/image']['lightbox'] ?? array();
-		$this->assertArrayNotHasKey( 'enabled', $lightbox );
-		$this->assertArrayNotHasKey( 'allowEditing', $lightbox );
+		$this->assertArrayNotHasKey( 'enabled', $lightbox, 'Enabled should be removed' );
+		$this->assertArrayNotHasKey( 'allowEditing', $lightbox, 'Allow editing should be removed' );
 	}
 
 	/**
@@ -6748,7 +6748,7 @@ public function test_sanitize_preserves_null_schema_behavior() {
 		);
 
 		$settings = $theme_json->get_settings();
-		$this->assertSame( 'string-value', $settings['appearanceTools'] );
-		$this->assertSame( array( 'nested' => 'value' ), $settings['custom'] );
+		$this->assertSame( 'string-value', $settings['appearanceTools'], 'Appearance tools should be string value' );
+		$this->assertSame( array( 'nested' => 'value' ), $settings['custom'], 'Custom should be array value' );
 	}
 }