Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight color for text doesn't match the color palette #372

Open
josephahaden opened this issue Apr 29, 2022 · 2 comments · May be fixed by #375
Open

Highlight color for text doesn't match the color palette #372

josephahaden opened this issue Apr 29, 2022 · 2 comments · May be fixed by #375

Comments

@josephahaden
Copy link

When selecting copy with a post (whether a written post or the podcast), the highlight color is red. I don't know if that was an intentional choice, but it's probably worth a designer's eye to confirm.

Screen Shot 2022-04-29 at 10 45 15 AM

@ryelle
Copy link
Contributor

ryelle commented May 3, 2022

This was done intentionally - I thought I remembered this from the design, but after a quick scan of the figma I can't find it. The red is one of the site colors though, you can see it on the security page.

cc @beafialho if you have anything to add.

@beafialho
Copy link
Collaborator

Thank you for flagging this @josephahaden!

My memory has faded as I also thought we had discussed this, even though I don't remember mocking this up on Figma...

My first option for highlighted text in posts would be the light blue:
Captura de ecrã 2022-05-04, às 16 30 52

But that would probably need to be updated everywhere since in other areas there seems to be a red highlight color as well:

Captura de ecrã 2022-05-04, às 16 32 14

Captura de ecrã 2022-05-04, às 16 32 33

Captura de ecrã 2022-05-04, às 16 33 03

Red passes AA contrast checks but blue passes AAA. @ryelle would I need to mock that up for every bg color or is that something we can update quite easily?

@ryelle ryelle linked a pull request May 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants