Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement design for posts & content #9

Closed
10 of 21 tasks
iandunn opened this issue Aug 12, 2021 · 4 comments
Closed
10 of 21 tasks

Implement design for posts & content #9

iandunn opened this issue Aug 12, 2021 · 4 comments
Labels
Help Wanted Extra attention is needed [Type] Enhancement New feature or request [Type] Tracking Summarizes and tracks a collection of issues

Comments

@iandunn
Copy link
Member

iandunn commented Aug 12, 2021

https://www.figma.com/file/O9I8Jl7kaUMTX39LlRGbGO/News-Page?node-id=4659%3A8682

each of these should have it's own PR (and an issue too, if needed)

full width (default)

content width

blocks

@iandunn iandunn added the [Type] Enhancement New feature or request label Aug 12, 2021
@iandunn iandunn added this to the Initial Launch milestone Aug 12, 2021
@iandunn iandunn added the Help Wanted Extra attention is needed label Oct 18, 2021
@iandunn iandunn added the [Type] Tracking Summarizes and tracks a collection of issues label Dec 14, 2021
@coreymckrill
Copy link
Contributor

@iandunn I'm trying to figure out how many of these checklist items still need to be done, but I'm not sure what some of them are referring to:

  • content width alignment - is this a specific block or just the fact that the content column is supposed to be on the right side on desktop widths? If the latter, I think this one is done, right?
  • contributors break 1, 2, 3 - what are these referring to?

@iandunn
Copy link
Member Author

iandunn commented Feb 24, 2022

IIRC they were all phrases used in the mockup

content width alignment

https://www.figma.com/file/O9I8Jl7kaUMTX39LlRGbGO/News-Page?node-id=4659%3A11896

contributors break 1, 2, 3

https://www.figma.com/file/O9I8Jl7kaUMTX39LlRGbGO/News-Page?node-id=4764%3A24504

@coreymckrill
Copy link
Contributor

full width images

Captions were addressed in #275, ensuring that existing posts use the full-width alignment is more of a content issue.

@coreymckrill
Copy link
Contributor

Ok, the remaining checklist items above fit into three issues, which have all now been created. I'm going to close this to declutter the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed [Type] Enhancement New feature or request [Type] Tracking Summarizes and tracks a collection of issues
Projects
None yet
Development

No branches or pull requests

2 participants