Skip to content

MGRS conversion fixes #67

Closed
Closed
@wcmatthysen

Description

@wcmatthysen
Member

Pull in fixes for MGRS coordinate conversion from upstream PR #157 of @gbburkhardt. The corresponding description from the PR is:

Fix two problems:

a) Index out of bounds error due to typo in convertMGRSToUPS; clearly the index should have been 1 instead of 12.
b) Conversions from geodetic to MGRS would fail for low southern latitudes (zone 0). Geotrans 3.7 has this problem fixed. The WorldWind conversion code was derived from NGA's Geotrans. Test case:
Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747

See issue #160 in upstream repository as well.

Activity

added this to the WWJ-CE 2.2.0 milestone on Aug 7, 2019
EMaksymenko

EMaksymenko commented on Aug 7, 2019

@EMaksymenko
Member

By the way, I have ported this conversions earlier to Android code base.
So I probably need to copy this fixes to Android branch too.
Will wait the result.

WorldWindEarth/WorldWindAndroid#16

wcmatthysen

wcmatthysen commented on Aug 14, 2019

@wcmatthysen
MemberAuthor

OK, the fix for this was done in PR #72. I'll take a look at porting the fixes to the Android code-base before closing this issue.

PJHogan

PJHogan commented on Aug 14, 2019

@PJHogan
Member

You guys are AMAZING! Nice work!

wcmatthysen

wcmatthysen commented on Aug 19, 2019

@wcmatthysen
MemberAuthor

The fixes are now ported to the Android code-base. So, I guess we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @wcmatthysen@EMaksymenko@PJHogan

        Issue actions

          MGRS conversion fixes · Issue #67 · WorldWindEarth/WorldWindJava