64-bit build creates bad ISOs

[mborgerson]

I'm not sure why yet but building in 64b mode creates a reproducible bad ISO with the "Halo 2 Multiplayer Map Pack" and "Call of Duty: Big Red One" game files (which I've ripped from my discs, verified to work on my real Xbox).

When running H2:MMP with such a faulty ISO, the game will start but it will fail to install update the game executable and report "out of space" errors when trying to install the maps. In CoD:BRO, the game will report dirty disc errors before getting to the main menu. (Fixed in #52)

In both cases, building in 32-bit mode yields a fully-functional ISO. Suggest updating CI to build in 32-bit mode until this can be fixed.

Thanks to @Ernegien for helping me debug this issue!

[abaire]

This also triggers a crash in "Return To Castle Wolfenstein" (see thread in mborgerson/xemu#509)

[Shoegzer]

I found this issue after converting an ISO dump to XISO resulted in a bad dump. extract-iso was compiled with 64-bit linux - a 32-bit version can't be compiled without a 32-bit OS or chroot environment.

Others too are submitting more issue reports in xemu that have nothing to do with the emulator but are related to bad dumps, I'm sure that's distracting for its devs, and though I'm not sure if part of the reason for so many can be traced here it seems possible.

As a side note, I'm not sure what roadblocks exist for xemu to support full ISOs but that would be nice, even if 1:1 dumps take more hard drive space I think they're better than lossy alternatives in the long run with all things considered.

[mborgerson]

You can build a 32b executable @Shoegzer you just need gcc-multilib and to specify -m32

[Shoegzer]

Thanks @mborgerson. I tried gcc -m32 extract-xiso.c -o extract-xiso, but it threw an "unknown target" exception followed by further exceptions. How can the linux target be specified? Normally I'd do that with configure --target=linux.

[Shoegzer]

Update: here is the first part of the compile log in case it helps. I can add more if necessary, but I believe all the errors stem from lack of a specified target. I had previously been compiling with CMake but didn't here since the -m32 flag can't be used with CMake specifically and there doesn't appear to be anything supporting a 32-bit build in CMakeLists.

[abaire]

You can edit CMakeLists to add "-m32" to compile and link flags for the target. If you do a trivial search for "cmake" "32 bit" there are a number of examples.

@mborgerson given that we know 64-bit builds are still problematic, would it be reasonable to either force 32-bit in the makefile (maybe with a warning so developers seeking to fix 64 bit will be aware?) or update CI to do 32-bit releases for all platforms so there are fewer people doing incorrect builds and seeking support here/on Discord?

[dracc]

For the lazy: Adding

target_compile_options(extract-xiso PUBLIC -m32)
target_link_options(extract-xiso PUBLIC -m32)

to the CMakeLists.txt file works (for me) after installing gcc-multilib.

[mborgerson]

@mborgerson given that we know 64-bit builds are still problematic, would it be reasonable to either force 32-bit in the makefile (maybe with a warning so developers seeking to fix 64 bit will be aware?) or update CI to do 32-bit releases for all platforms so there are fewer people doing incorrect builds and seeking support here/on Discord?

@abaire I think so, yes (to both)