Skip to content

fix: preserve paused auto-scroll on completion #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YishenTu merged 2 commits into from
Feb 28, 2026
Merged

fix: preserve paused auto-scroll on completion #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90c4de9
fix: preserve paused auto-scroll after completion
YishenTu Feb 28, 2026
6f864ab
test: remove local page-text plugin unit test
YishenTu Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/chatpanel/app/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,7 @@ export function mountChatPanel(): void {
});

const messageRenderOptions: MessageRenderOptions = {
shouldAutoScroll: (reason) =>
reason === 'render-all' || messageListAutoScrollState.shouldAutoScroll(),
shouldAutoScroll: () => messageListAutoScrollState.shouldAutoScroll(),
onAssistantAction: (action, message) => {
if (!conversationFlow) {
return;
Expand Down
9 changes: 8 additions & 1 deletion tests/unit/chatpanel/app/regen-flow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,9 @@ describe('chatpanel regenerate flow', () => {
await flushMicrotasks(6);
expect(messageList.scrollTop).toBe(700);

messageList.scrollTop = 600;
messageList.dispatchEvent(new testWindow.Event('scroll'));

currentMessages = [
{ id: 'persisted-user-2', role: 'user', content: 'second prompt' },
{
Expand All @@ -1048,7 +1051,11 @@ describe('chatpanel regenerate flow', () => {
},
},
});
await flushMicrotasks(20);
simulatedScrollHeight = 760;
const loadCountBeforeSecondCompletion = loadRequests.length;
await flushMicrotasks(80);
expect(loadRequests.length).toBeGreaterThan(loadCountBeforeSecondCompletion);
expect(messageList.scrollTop).toBe(600);
});

it('shows image previews inline within the chatpanel for staged and message attachments', async () => {
Expand Down
99 changes: 0 additions & 99 deletions tests/unit/plugins/page-text-extraction/nga-bbs-cn.plugin.test.ts
View file
Open in desktop

This file was deleted.