Skip to content

Commit 6456b09

Browse files
authored
Merge pull request #789 from airbnb/consolidated-events-api
Update consolidated-events usage to newer API
2 parents dffffea + 28313de commit 6456b09

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/components/CalendarMonthGrid.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import momentPropTypes from 'react-moment-proptypes';
55
import { forbidExtraProps, nonNegativeInteger } from 'airbnb-prop-types';
66
import { css, withStyles, withStylesPropTypes } from 'react-with-styles';
77
import moment from 'moment';
8-
import { addEventListener, removeEventListener } from 'consolidated-events';
8+
import { addEventListener } from 'consolidated-events';
99

1010
import { CalendarDayPhrases } from '../defaultPhrases';
1111
import getPhrasePropTypes from '../utils/getPhrasePropTypes';
@@ -113,7 +113,7 @@ class CalendarMonthGrid extends React.Component {
113113

114114
componentDidMount() {
115115
const { setCalendarMonthHeights } = this.props;
116-
this.eventHandle = addEventListener(
116+
this.removeEventListener = addEventListener(
117117
this.container,
118118
'transitionend',
119119
this.onTransitionEnd,
@@ -173,7 +173,7 @@ class CalendarMonthGrid extends React.Component {
173173
}
174174

175175
componentWillUnmount() {
176-
removeEventListener(this.eventHandle);
176+
if (this.removeEventListener) this.removeEventListener();
177177
if (this.setCalendarMonthHeightsTimeout) {
178178
clearTimeout(this.setCalendarMonthHeightsTimeout);
179179
}

src/components/DateRangePicker.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import moment from 'moment';
44
import { css, withStyles, withStylesPropTypes } from 'react-with-styles';
55
import Portal from 'react-portal';
66
import { forbidExtraProps } from 'airbnb-prop-types';
7-
import { addEventListener, removeEventListener } from 'consolidated-events';
7+
import { addEventListener } from 'consolidated-events';
88
import isTouchDevice from 'is-touch-device';
99

1010
import { DateRangePickerPhrases } from '../defaultPhrases';
@@ -128,7 +128,7 @@ class DateRangePicker extends React.Component {
128128
}
129129

130130
componentDidMount() {
131-
this.resizeHandle = addEventListener(
131+
this.removeEventListener = addEventListener(
132132
window,
133133
'resize',
134134
this.responsivizePickerPosition,
@@ -157,7 +157,7 @@ class DateRangePicker extends React.Component {
157157
}
158158

159159
componentWillUnmount() {
160-
if (this.resizeHandle) removeEventListener(this.resizeHandle);
160+
if (this.removeEventListener) this.removeEventListener();
161161
}
162162

163163
onOutsideClick() {

src/components/OutsideClickHandler.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22
import PropTypes from 'prop-types';
33

44
// import { forbidExtraProps } from 'airbnb-prop-types'; // TODO: add to propTypes; semver-major
5-
import { addEventListener, removeEventListener } from 'consolidated-events';
5+
import { addEventListener } from 'consolidated-events';
66

77
const propTypes = {
88
children: PropTypes.node,
@@ -25,7 +25,7 @@ export default class OutsideClickHandler extends React.Component {
2525
componentDidMount() {
2626
// `capture` flag is set to true so that a `stopPropagation` in the children
2727
// will not prevent all outside click handlers from firing - maja
28-
this.clickHandle = addEventListener(
28+
this.removeEventListener = addEventListener(
2929
document,
3030
'click',
3131
this.onOutsideClick,
@@ -34,7 +34,7 @@ export default class OutsideClickHandler extends React.Component {
3434
}
3535

3636
componentWillUnmount() {
37-
if (this.clickHandle) { removeEventListener(this.clickHandle); }
37+
if (this.removeEventListener) { this.removeEventListener(); }
3838
}
3939

4040
onOutsideClick(e) {

src/components/SingleDatePicker.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import moment from 'moment';
33
import { css, withStyles, withStylesPropTypes } from 'react-with-styles';
44
import Portal from 'react-portal';
55
import { forbidExtraProps } from 'airbnb-prop-types';
6-
import { addEventListener, removeEventListener } from 'consolidated-events';
6+
import { addEventListener } from 'consolidated-events';
77
import isTouchDevice from 'is-touch-device';
88

99
import SingleDatePickerShape from '../shapes/SingleDatePickerShape';
@@ -125,7 +125,7 @@ class SingleDatePicker extends React.Component {
125125

126126
/* istanbul ignore next */
127127
componentDidMount() {
128-
this.resizeHandle = addEventListener(
128+
this.removeEventListener = addEventListener(
129129
window,
130130
'resize',
131131
this.responsivizePickerPosition,
@@ -150,7 +150,7 @@ class SingleDatePicker extends React.Component {
150150

151151
/* istanbul ignore next */
152152
componentWillUnmount() {
153-
removeEventListener(this.resizeHandle);
153+
if (this.removeEventListener) this.removeEventListener();
154154
}
155155

156156
onChange(dateString) {

0 commit comments

Comments
 (0)