Allow user attach multiple eips to one nic

Delete all checks for multi-eip binding to one nic
and change query getAttachableVmNicForEip
to make it returns the nics has other EIP attached.

For zxwing/premium#1678

Author: MatheMatrix

plugin/eip/src/main/java/org/zstack/network/service/eip/EipApiInterceptor.java

@@ -88,8 +88,6 @@ private void validate(APIGetEipAttachableVmNicsMsg msg) {
     }
 
     private void validate(final APIAttachEipMsg msg) {
-        isVmNicUsed(msg.getVmNicUuid());
-
         SimpleQuery<EipVO> q = dbf.createQuery(EipVO.class);
         q.select(EipVO_.state, EipVO_.vmNicUuid, EipVO_.vipIp);
         q.add(EipVO_.uuid, Op.EQ, msg.getEipUuid());
@@ -110,14 +108,6 @@ private void validate(final APIAttachEipMsg msg) {
             ));
         }
 
-        q = dbf.createQuery(EipVO.class);
-        q.add(EipVO_.vmNicUuid, Op.EQ, msg.getVmNicUuid());
-        if (q.isExists()) {
-            throw new ApiMessageInterceptionException(errf.stringToOperationError(
-                    String.format("the VM nic[uuid:%s] already has another EIP attached", msg.getVmNicUuid())
-            ));
-        }
-
         String vipIp = t.get(2, String.class);
         isVipInVmNicSubnet(vipIp, msg.getVmNicUuid());
 
@@ -167,18 +157,6 @@ private void validate(APIDeleteEipMsg msg) {
         }
     }
 
-    private void isVmNicUsed(String vmNicUuid) {
-        SimpleQuery<EipVO> eq = dbf.createQuery(EipVO.class);
-        eq.select(EipVO_.uuid);
-        eq.add(EipVO_.vmNicUuid, Op.EQ, vmNicUuid);
-        String eipUuid = eq.findValue();
-        if (eipUuid != null) {
-            throw new ApiMessageInterceptionException(errf.instantiateErrorCode(SysErrors.OPERATION_ERROR,
-                    String.format("vm nic[uuid:%s] has attached to another eip[uuid:%s]", vmNicUuid, eipUuid)
-            ));
-        }
-    }
-
     private void isVipInVmNicSubnet(String eipIp, String vmNicUuid) {
         SimpleQuery<VmNicVO> q = dbf.createQuery(VmNicVO.class);
         q.select(VmNicVO_.gateway, VmNicVO_.netmask);
@@ -212,10 +190,6 @@ private void checkIfVmAlreadyHasVipNetwork(String vmUuid, VipVO vip) {
     }
 
     private void validate(APICreateEipMsg msg) {
-        if (msg.getVmNicUuid() != null) {
-            isVmNicUsed(msg.getVmNicUuid());
-        }
-
         VipVO vip = dbf.findByUuid(msg.getVipUuid(), VipVO.class);
         if (vip.getUseFor() != null) {
             throw new ApiMessageInterceptionException(errf.instantiateErrorCode(SysErrors.OPERATION_ERROR,
@@ -230,14 +204,6 @@ private void validate(APICreateEipMsg msg) {
         }
 
         if (msg.getVmNicUuid() != null) {
-            SimpleQuery<EipVO> q = dbf.createQuery(EipVO.class);
-            q.add(EipVO_.vmNicUuid, Op.EQ, msg.getVmNicUuid());
-            if (q.isExists()) {
-                throw new ApiMessageInterceptionException(errf.stringToOperationError(
-                        String.format("the VM nic[uuid:%s] already has another EIP attached", msg.getVmNicUuid())
-                ));
-            }
-
             isVipInVmNicSubnet(vip.getIp(), msg.getVmNicUuid());
 
             SimpleQuery<VmNicVO> nicq = dbf.createQuery(VmNicVO.class);

plugin/eip/src/main/java/org/zstack/network/service/eip/EipManagerImpl.java

@@ -175,8 +175,7 @@ private List<VmNicInventory> getAttachableVmNicForEip(String eipUuid, String vip
                 " from VmNicVO nic, VmInstanceVO vm" +
                 " where nic.l3NetworkUuid in (:l3Uuids)" +
                 " and nic.vmInstanceUuid = vm.uuid" +
-                " and vm.type = :vmType and vm.state in (:vmStates)" +
-                " and nic.uuid not in (select eip.vmNicUuid from EipVO eip where eip.vmNicUuid is not null)";
+                " and vm.type = :vmType and vm.state in (:vmStates)";
         TypedQuery<VmNicVO> nq = dbf.getEntityManager().createQuery(sql, VmNicVO.class);
         nq.setParameter("l3Uuids", l3Uuids);
         nq.setParameter("vmType", VmInstanceConstant.USER_VM_TYPE);