fix linting issues

Author: nikgraf

.eslintrc.js

@@ -11,6 +11,7 @@ module.exports = {
     "import/no-extraneous-dependencies" : "off"
   },
   "env": {
-       "mocha": true
+       "mocha": true,
+       "jest": true
    }
 };

tests/integration/aws/api-gateway/integration-lambda-proxy/api-keys/tests.js

@@ -67,13 +67,14 @@ it('should reject a request with an invalid API Key', () => fetch(endpoint)
   })
 );
 
-it('should succeed if correct API key is given', () => fetch(endpoint, { headers: { 'x-api-key': apiKey } })
-  .then(response => response.json())
-  .then((json) => {
-    expect(json.message).to.equal('Hello from API Gateway!');
-    expect(json.event.requestContext.identity.apiKey).to.equal(apiKey);
-    expect(json.event.headers['x-api-key']).to.equal(apiKey);
-  })
+it('should succeed if correct API key is given', () =>
+  fetch(endpoint, { headers: { 'x-api-key': apiKey } })
+    .then(response => response.json())
+    .then((json) => {
+      expect(json.message).to.equal('Hello from API Gateway!');
+      expect(json.event.requestContext.identity.apiKey).to.equal(apiKey);
+      expect(json.event.headers['x-api-key']).to.equal(apiKey);
+    })
 );
 
 afterAll(() => {

tests/integration/aws/api-gateway/integration-lambda-proxy/cors/tests.js

@@ -44,15 +44,16 @@ beforeAll(() => fetch(`${endpointBase}/simple-cors`, { method: 'OPTIONS' })
     })
 );
 
-it('should setup CORS support with complex object config', () => fetch(`${endpointBase}/complex-cors`, { method: 'OPTIONS' })
-  .then((response) => {
-    const headers = response.headers;
-
-    expect(headers.get('access-control-allow-headers'))
-      .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
-    expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
-    expect(headers.get('access-control-allow-origin')).to.equal('*');
-  })
+it('should setup CORS support with complex object config', () =>
+  fetch(`${endpointBase}/complex-cors`, { method: 'OPTIONS' })
+    .then((response) => {
+      const headers = response.headers;
+
+      expect(headers.get('access-control-allow-headers'))
+        .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
+      expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
+      expect(headers.get('access-control-allow-origin')).to.equal('*');
+    })
 );
 
 afterAll(() => {

tests/integration/aws/api-gateway/integration-lambda-proxy/custom-authorizers/tests.js

@@ -39,19 +39,21 @@ it('should reject requests without authorization', () => fetch(endpoint)
   })
 );
 
-it('should reject requests with wrong authorization', () => fetch(endpoint, { headers: { Authorization: 'Bearer ShouldNotBeAuthorized' } })
-  .then((response) => {
-    expect(response.status).to.equal(401);
-  })
+it('should reject requests with wrong authorization', () =>
+  fetch(endpoint, { headers: { Authorization: 'Bearer ShouldNotBeAuthorized' } })
+    .then((response) => {
+      expect(response.status).to.equal(401);
+    })
 );
 
-it('should authorize requests with correct authorization', () => fetch(endpoint, { headers: { Authorization: 'Bearer ShouldBeAuthorized' } })
-  .then(response => response.json())
-  .then((json) => {
-    expect(json.message).to.equal('Successfully authorized!');
-    expect(json.event.requestContext.authorizer.principalId).to.equal('SomeRandomId');
-    expect(json.event.headers.Authorization).to.equal('Bearer ShouldBeAuthorized');
-  })
+it('should authorize requests with correct authorization', () =>
+  fetch(endpoint, { headers: { Authorization: 'Bearer ShouldBeAuthorized' } })
+    .then(response => response.json())
+    .then((json) => {
+      expect(json.message).to.equal('Successfully authorized!');
+      expect(json.event.requestContext.authorizer.principalId).to.equal('SomeRandomId');
+      expect(json.event.headers.Authorization).to.equal('Bearer ShouldBeAuthorized');
+    })
 );
 
 afterAll(() => {

tests/integration/aws/api-gateway/integration-lambda/api-keys/tests.js

@@ -70,13 +70,14 @@ it('should reject a request with an invalid API Key', () => fetch(endpoint)
   })
 );
 
-it('should succeed if correct API key is given', () => fetch(endpoint, { headers: { 'x-api-key': apiKey } })
-  .then(response => response.json())
-  .then((json) => {
-    expect(json.message).to.equal('Hello from API Gateway!');
-    expect(json.event.identity.apiKey).to.equal(apiKey);
-    expect(json.event.headers['x-api-key']).to.equal(apiKey);
-  })
+it('should succeed if correct API key is given', () =>
+  fetch(endpoint, { headers: { 'x-api-key': apiKey } })
+    .then(response => response.json())
+    .then((json) => {
+      expect(json.message).to.equal('Hello from API Gateway!');
+      expect(json.event.identity.apiKey).to.equal(apiKey);
+      expect(json.event.headers['x-api-key']).to.equal(apiKey);
+    })
 );
 
 afterAll(() => {

tests/integration/aws/api-gateway/integration-lambda/cors/tests.js

@@ -30,26 +30,28 @@ beforeAll(() => CF.describeStacksPromised({ StackName: stackName })
     })
 );
 
-it('should setup CORS support with simple string config', () => fetch(`${endpointBase}/simple-cors`, { method: 'OPTIONS' })
-  .then((response) => {
-    const headers = response.headers;
-
-    expect(headers.get('access-control-allow-headers'))
-      .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
-    expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
-    expect(headers.get('access-control-allow-origin')).to.equal('*');
-  })
+it('should setup CORS support with simple string config', () =>
+  fetch(`${endpointBase}/simple-cors`, { method: 'OPTIONS' })
+    .then((response) => {
+      const headers = response.headers;
+
+      expect(headers.get('access-control-allow-headers'))
+        .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
+      expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
+      expect(headers.get('access-control-allow-origin')).to.equal('*');
+    })
 );
 
-it('should setup CORS support with complex object config', () => fetch(`${endpointBase}/complex-cors`, { method: 'OPTIONS' })
-  .then((response) => {
-    const headers = response.headers;
+it('should setup CORS support with complex object config', () =>
+  fetch(`${endpointBase}/complex-cors`, { method: 'OPTIONS' })
+    .then((response) => {
+      const headers = response.headers;
 
-    expect(headers.get('access-control-allow-headers'))
-      .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
-    expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
-    expect(headers.get('access-control-allow-origin')).to.equal('*');
-  })
+      expect(headers.get('access-control-allow-headers'))
+        .to.equal('Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token');
+      expect(headers.get('access-control-allow-methods')).to.equal('OPTIONS,GET');
+      expect(headers.get('access-control-allow-origin')).to.equal('*');
+    })
 );
 
 afterAll(() => {

tests/integration/aws/api-gateway/integration-lambda/custom-authorizers/tests.js

@@ -37,19 +37,21 @@ it('should reject requests without authorization', () => fetch(endpoint)
   })
 );
 
-it('should reject requests with wrong authorization', () => fetch(endpoint, { headers: { Authorization: 'Bearer ShouldNotBeAuthorized' } })
-  .then((response) => {
-    expect(response.status).to.equal(401);
-  })
+it('should reject requests with wrong authorization', () =>
+  fetch(endpoint, { headers: { Authorization: 'Bearer ShouldNotBeAuthorized' } })
+    .then((response) => {
+      expect(response.status).to.equal(401);
+    })
 );
 
-it('should authorize requests with correct authorization', () => fetch(endpoint, { headers: { Authorization: 'Bearer ShouldBeAuthorized' } })
-  .then(response => response.json())
-  .then((json) => {
-    expect(json.message).to.equal('Successfully authorized!');
-    expect(json.event.principalId).to.equal('SomeRandomId');
-    expect(json.event.headers.Authorization).to.equal('Bearer ShouldBeAuthorized');
-  })
+it('should authorize requests with correct authorization', () =>
+  fetch(endpoint, { headers: { Authorization: 'Bearer ShouldBeAuthorized' } })
+    .then(response => response.json())
+    .then((json) => {
+      expect(json.message).to.equal('Successfully authorized!');
+      expect(json.event.principalId).to.equal('SomeRandomId');
+      expect(json.event.headers.Authorization).to.equal('Bearer ShouldBeAuthorized');
+    })
 );
 
 afterAll(() => {

tests/integration/aws/general/custom-resources/tests.js

@@ -36,12 +36,13 @@ beforeAll(() => {
   Utils.deployService();
 });
 
-it('should add the custom outputs to the Outputs section', () => CF.describeStacksPromised({ StackName: stackName })
-  .then((result) => _.find(result.Stacks[0].Outputs,
-    { OutputKey: 'MyCustomOutput' }).OutputValue)
-  .then((endpointOutput) => {
-    expect(endpointOutput).to.equal('SomeValue');
-  })
+it('should add the custom outputs to the Outputs section', () =>
+  CF.describeStacksPromised({ StackName: stackName })
+    .then((result) => _.find(result.Stacks[0].Outputs,
+      { OutputKey: 'MyCustomOutput' }).OutputValue)
+    .then((endpointOutput) => {
+      expect(endpointOutput).to.equal('SomeValue');
+    })
 );
 
 it('should create the custom resources (a S3 bucket)', () => S3.listBucketsPromised()

tests/setupTests.js

@@ -1,2 +1,3 @@
 // timeout is set to 5 minutes
+// eslint-disable-next-line no-undef
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;