-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: improve type encapsulation in reassembly module #12
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestinfrastructureBuild, perf, toolingBuild, perf, tooling
Description
Summary
Type design improvements for the reassembly module identified during PR #10 review.
Items
- Make FlowKey fields private, add read-only accessors — prevents HashMap key mutation
- Move insert_segment/flush_contiguous into impl FlowDirection — consolidates mutation
- Extract flush-and-remove helper — deduplicate pattern used in RST, FIN, expire, evict, finalize
- Add max_receive_window to reject segments far ahead of base_offset
Acceptance Criteria
- FlowKey fields private with accessors
- Segment operations are methods on FlowDirection
- Single
close_flow()helper used by all removal paths - Segments beyond base_offset + max_window are rejected
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestinfrastructureBuild, perf, toolingBuild, perf, tooling