Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

King County COVID19 - Bug: Navigation to translated pages appears as buttons but works like hyperlinks #22

Open
alboss opened this issue May 12, 2020 · 1 comment
Labels
bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site

Comments

@alboss
Copy link

alboss commented May 12, 2020

Issue Summary

Links to translated pages are formatted to look like buttons. This causes accessibility issues, because you activate links and buttons with different keys.

There are also UX issues with this, because things that look like buttons generally perform actions, whereas things that look like links are ordinarily used for navigation.

Note: menus like the kingcounty.gov left-hand navigation tend to blur those boundaries. Responsive design often reuses the same style for phones (where a menu takes over the screen and actually should be buttons) and larger screens (where a menu is really links to other pages). We didn't know better in 2013. We do now.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to https://kingcounty.gov/depts/health/covid-19.aspx
  2. Scroll about halfway down to the available translations
  3. Click the button for any language

Behavior

  • A new page loads.

Expected behavior

  • A link navigates the user to a new resource, taking them away from the current context (internal links are the only wrinkle here). A button toggles something in the interface, like a video player; or triggers new content in that same context, like a popup menu using aria-haspopup. (Source: marcysutton.com)

Actual behavior

  • Clicking takes you to a completely different page, because what looks like buttons are actually hyperlinks.

Versions

  • All

Device Information:

  • OS: all
  • Browser: all
  • Version: all

Code

Current Code

<a class="btn btn-primary btn-block" href="/depts/health/covid-19/languages/ASL.aspx" 
role="button" data-toggle="tooltip" data-placement="left" title="" 
data-original-title="COVID-19 resources in American Sign Language for the 
Deaf/Hard of Hearing and DeafBlind">ASL for D/HOH &amp; DB</a>

Suggested Code

Difficult to say. Obviously you want some sort of stylistic choice that makes these links differentiated from the rest of the page. Perhaps use list groups?

<ul class="list-group">
  <li class="list-group-item">
     <a href="/depts/health/covid-19/languages/ASL.aspx" data-toggle="tooltip" 
data-placement="left" title="" data-original-title="COVID-19 resources in 
American Sign Language for the Deaf/Hard of Hearing and 
DeafBlind">ASL for D/HOH &amp; DB</a>
  </li>
  <li class="list-group-item"> (for each language option) </li>
</ul>

Specifications

Additional References

@smhigley smhigley added bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site labels May 14, 2020
@alboss
Copy link
Author

alboss commented May 21, 2020

I'll pass this on to the Public Health webmaster. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site
Projects
None yet
Development

No branches or pull requests

2 participants