Skip to content

chore: bring back removed files#700

Merged
ishymko merged 1 commit into1.0-devfrom
ishymko/restore
Feb 18, 2026
Merged

chore: bring back removed files#700
ishymko merged 1 commit into1.0-devfrom
ishymko/restore

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Feb 18, 2026

Bring back .pre-commit-config.yaml and disabled JSCPD linter.

Removal can be evaluated separately, for now bringing them back to make diff against main more focused.

Tested (as an evidence that Gemini comments about bad versions are not accurate):

$ uv run pre-commit
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check toml...........................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
check for merge conflicts............................(no files to check)Skipped
detect private key...................................(no files to check)Skipped
taplo-format.........................................(no files to check)Skipped
taplo-lint...........................................(no files to check)Skipped
yamlfix..............................................(no files to check)Skipped
no_implicit_optional.................................(no files to check)Skipped
pyupgrade............................................(no files to check)Skipped
autoflake............................................(no files to check)Skipped
ruff (legacy alias)..................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
uv-lock..............................................(no files to check)Skipped
Detect hardcoded secrets.............................(no files to check)Skipped

Re #559.

Bring back `.pre-commit-config.yaml` and disabled JSCPD linter.

Re #559.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to reinstate the pre-commit configuration file and disable a specific linter, likely to restore previous functionality or address issues introduced by recent changes. The reintroduction of the configuration file suggests a return to established code quality and formatting standards.

Highlights

  • File Restoration: This PR brings back the .pre-commit-config.yaml file, which was previously removed.
  • Linter Configuration: The PR also disables the JSCPD linter, as mentioned in the description.
  • Issue Resolution: This PR addresses and resolves issue [Feat]: Upgrade A2A to v1.0 #559.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/linter.yaml
Activity
  • The PR author, ishymko, has restored the .pre-commit-config.yaml file and disabled the JSCPD linter.
  • The PR description references issue [Feat]: Upgrade A2A to v1.0 #559, indicating a resolution or related change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ishymko ishymko marked this pull request as ready for review February 18, 2026 09:18
@ishymko ishymko requested a review from a team as a code owner February 18, 2026 09:18
@ishymko ishymko merged commit b306e44 into 1.0-dev Feb 18, 2026
10 checks passed
@ishymko ishymko deleted the ishymko/restore branch February 18, 2026 09:18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-introduces the .pre-commit-config.yaml file to set up pre-commit hooks for the project. While the selection of hooks is good, several of the specified revisions (rev) for the hooks are invalid and will cause pre-commit to fail during setup. I've left specific comments with suggestions for valid versions. Please update these to ensure the pre-commit hooks can be installed and run correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant