Conversation
Bring back `.pre-commit-config.yaml` and disabled JSCPD linter. Re #559.
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to reinstate the pre-commit configuration file and disable a specific linter, likely to restore previous functionality or address issues introduced by recent changes. The reintroduction of the configuration file suggests a return to established code quality and formatting standards. Highlights
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request re-introduces the .pre-commit-config.yaml file to set up pre-commit hooks for the project. While the selection of hooks is good, several of the specified revisions (rev) for the hooks are invalid and will cause pre-commit to fail during setup. I've left specific comments with suggestions for valid versions. Please update these to ensure the pre-commit hooks can be installed and run correctly.
Bring back
.pre-commit-config.yamland disabled JSCPD linter.Removal can be evaluated separately, for now bringing them back to make diff against
mainmore focused.Tested (as an evidence that Gemini comments about bad versions are not accurate):
Re #559.