Skip to content

test: add e2e client-server test#704

Merged
ishymko merged 1 commit into1.0-devfrom
ishymko/coverage
Feb 18, 2026
Merged

test: add e2e client-server test#704
ishymko merged 1 commit into1.0-devfrom
ishymko/coverage

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Feb 18, 2026

Tests basic functionality with real client and server with real handlers, only agent executor is provided in test as it'd be in a real usage.

Re #559

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's testing infrastructure by adding a new suite of end-to-end tests. These tests are designed to verify the seamless interaction between client and server components across different transport layers, ensuring the core functionalities behave as expected in a real-world usage scenario. The addition of these tests improves the robustness and reliability of the system by catching potential integration issues early.

Highlights

  • New End-to-End Test Suite: Introduced a new comprehensive end-to-end test file (test_end_to_end.py) to validate client-server interactions.
  • Multi-Protocol Testing: The tests cover various communication protocols including REST, JSON-RPC, and gRPC, ensuring broad compatibility.
  • Core Functionality Validation: Validated key functionalities such as blocking, non-blocking, and streaming send_message operations, as well as get_task and list_tasks.
  • Mock Agent Executor: A MockAgentExecutor was implemented to simulate agent behavior, allowing for isolated testing of the client-server communication flow.
Changelog
  • tests/integration/test_end_to_end.py
    • Added a new file for end-to-end client-server integration tests.
    • Implemented MockAgentExecutor to simulate agent responses.
    • Created fixtures for setting up in-memory REST, JSON-RPC, and gRPC environments.
    • Included tests for send_message in blocking, non-blocking, and streaming modes across all supported protocols.
    • Added tests for get_task and list_tasks functionalities.
Activity
  • The pull request introduces a new test file, tests/integration/test_end_to_end.py, to add end-to-end client-server tests.
  • The changes address issue [Feat]: Upgrade A2A to v1.0 #559, indicating a prior discussion or requirement for these tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive suite of end-to-end tests for client-server interactions over REST, JSON-RPC, and gRPC transports. The tests cover blocking, non-blocking, and streaming send_message calls, as well as get_task and list_tasks functionality. The use of pytest fixtures for setting up different transport layers is well-structured.

I've provided a couple of suggestions to improve the maintainability and robustness of the tests:

  1. Refactoring the gRPC setup to avoid relying on a hardcoded list index.
  2. Consolidating duplicated HTTP and gRPC test functions into single, parametrized tests to reduce boilerplate code.

Overall, this is a great addition that significantly improves test coverage for the core functionality.

@ishymko ishymko force-pushed the ishymko/coverage branch 2 times, most recently from c592087 to 851a52c Compare February 18, 2026 11:57
@ishymko
Copy link
Member Author

ishymko commented Feb 18, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a valuable suite of end-to-end tests covering the client-server interaction for various transports (REST, JSON-RPC, gRPC) and messaging patterns. The use of parametrized pytest fixtures is excellent for code reuse and ensuring consistent testing across transports.

I've added a few suggestions for minor improvements to the test code, such as implementing the cancel method in the mock, avoiding direct modification of fixtures, and simplifying some assertions.

Additionally, I recommend expanding the test suite to include task cancellation once the cancel method is implemented. This would make the end-to-end test coverage even more comprehensive.

Tests basic functionality with real client and server with real handlers, only agent executor is provided in test as it'd be in a real usage.
@ishymko ishymko marked this pull request as ready for review February 18, 2026 12:23
@ishymko ishymko requested a review from a team as a code owner February 18, 2026 12:23
@ishymko ishymko merged commit e140694 into 1.0-dev Feb 18, 2026
9 checks passed
@ishymko ishymko deleted the ishymko/coverage branch February 18, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant