Skip to content

Incorrect commit matching #73

Description

@armallen

I recently updated from 1.3.7 to 1.3.11 and noticed the following:

Since 1.3.8, git log --format=%h is used to get commit shas and build commitSet. For my repos, it returns 8 characters shas.

Then, git blame -p is used to get the files shas, which returns 40 characters.

Finally, parseBlameForCommits uses fullSha.substring(0, 7), which is 7 characters. So we can't find the 8 characters shas in it, and no file change is detected.

The size of the sha returned by format=%h is dynamic and depends on the amount of commits in the repo, I think using %H and matching the 40 chars should fix the issue?

In the meantime, I'm relying on 1.3.7.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions