Skip to content

Review on version problem #1

@manikandanvengatesan

Description

@manikandanvengatesan

Read this blog for naming conventions

https://github.com/ahsiba/task_given/blob/71b521f798d8c0ab166584ebb18cd31dfbb61393/versions.ts#L1

Use proper interface like,

interface IVersion {
  id: string;
  name: string;
  releaseDate: Date;
  bugId: string[];
  features: string[];
  authors: string[];
  type: ERELEASE_TYPE;
} 

https://github.com/ahsiba/task_given/blob/71b521f798d8c0ab166584ebb18cd31dfbb61393/versions.ts#L46

write a single function instead of writing three different filters(code reusability). Do the same for all


https://github.com/ahsiba/task_given/blob/71b521f798d8c0ab166584ebb18cd31dfbb61393/versions.ts#L62

Do proper indentation, also this problem can be done in different way instead of pushing count in array and iterating the same again

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions