Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issues #2

Open
anthonyharrison opened this issue Aug 3, 2023 · 2 comments
Open

Minor issues #2

anthonyharrison opened this issue Aug 3, 2023 · 2 comments

Comments

@anthonyharrison
Copy link

After cloning the repo and then performing pip install .

  1. typecode-libmagic not installed. Get warning when using elf.get_elf_dependencies.
  2. get_elf_dependencies doesn't work if location is a symbolic link. Problem is actually in the get_type function in typecode.

Workarounds are:

  1. pip install typecode-libmagic
  2. call elf.get_elf_dependencies(location) with elf.get_elf_dependencies(os.path.realpath(location))
@pombredanne
Copy link
Member

@anthonyharrison Thanks... it has been designed to run as a ScanCode toolkit plugin and it does not use the [full] as it should have https://github.com/nexB/scancode-toolkit/blob/5dfcfcbbcda9a5bcd70a1fcf887babf661a87a03/setup.cfg#L124

@pombredanne
Copy link
Member

Actually we need typecode[full] as a reuirement to get the libmagic dep too

pombredanne added a commit that referenced this issue Aug 4, 2023
@pombredanne
Update install requirements setup.cfg
ff1c689 
We use typecode and need the [full] extra as a dependency

Reference: #2
Reported-by: Anthony Harrison <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne pombredanne mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @anthonyharrison