Fixed stutter due to very large tooltip text #519
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
|
Trimmed the tooltip text, If you want, we can change the trim character count |
|
@pombredanne ^^ |
|
LGTM! Thanks @OmkarPh! Tested and can confirm that the stutter is not present anymore after this fix is applied. |
| @@ -112,7 +112,7 @@ class BarChart { | |||
| tooltip | |||
There was a problem hiding this comment.
There's another .text() on line 96, is that something (and are there other places like this elsewhere in charts/others) that would also benefit from trimming potentially?
I'm not super familiar with .js or this codebase so I have no idea btw.
There was a problem hiding this comment.
That line is used to set the count for the bar which won't be that long character wise
to verify i added console log on that line to check what values are used there i.e.
.text((d) => { console.log('text being set on line 96 to', d.val); return '(' + d.val + ')'; })
It gave output:
and, about trimming at other places, I searched through a lot of files but only these 2 needed change
Fixes #444
Signed-off-by: Omkar Phansopkar [email protected]