-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build SCWB on Windows 10 #514
Comments
I got the same behaviour with Python 3.9.10 building SCWB 3.1.1 today. Best Regards |
There is some work in progress, but this in the HEAD of the develop branch, not in the tagged release yet. |
TL;DR: Regards
|
in general, I would prefer to avoid supporting building the tool on Windows. We are building it FOR use on Windows alright, but the build scripts are POSIX and are likely to work only on WSL2 (which is Linux and not Windows) and this is not tested. |
I disagree because the current purpose of SCWB is to view Scan results on your desktop. WSL on Windows is not desktop. When we have something like SCWB as a frontend for SCIO we would not want or need to support Windows directly. We seem to have the Windows build working currently for v4 so I am not sure that this is a priority issue. |
@mjherzog I am only talking about where we build SCWB, not where we run it. Run-wise we support Linux, Windows and macOS alright. But @johnmhoran also told me that we need to build on Windows for Windows anyway, so both of our points are likely moot. |
Requiring WSL for the build on Windows is fine if we can make it work. |
The current scancode workbench should work fine on Windows (WSL is not mandatory), Linux, and Mac (both x86 & arm64) since we're already using them in Github actions release CI. You can follow these steps: |
I discovered in recent days that I am unable to build the current version of SCWB on my Windows 10 laptop using Git Bash.
This process still works when I check out the latest tag --
v3.1.1
from the latest release, in September 2019 -- and build with Python 2.7.15.npm install
./node_modules/.bin/electron-rebuild
npm start
-- SCWB launched, looked good, displayed some data just fine/c/Python27/python.exe build.py
/dist/
folder, double clickScanCode-Workbench.exe
and no errors -- SCWB 3.1.1 opens, runs fine, looks great.With the current code, the 1st 3 steps work with both Python 2.7.15 and Python3 (3.8.3). No error during the build process, but when I try to run the built
.exe
I get a JavaScript error:Cannot find module '../dist/src/main'
.Not sure what is meant by
Cannot find module '../dist/src/main'
but can confirm there is no such folder. Same result when extracting the .zip and running the.exe
found there. I also get an error runningnpm test
.Perhaps I'm using the wrong version of
npm
, ornode.js
(but they look like they meet the RTD Windows requirements -- https://scancode-workbench.readthedocs.io/en/develop/contribute/building.html#windows)? (I have npm 5.2.0 and node 12.16.3.) Seems like some conflict was introduced after the 3.1.1 tag was created.The text was updated successfully, but these errors were encountered: