Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker thread support for "working" icon indicator #552

Open
mjherzog opened this issue Apr 4, 2023 · 5 comments · Fixed by #583
Open

Worker thread support for "working" icon indicator #552

mjherzog opened this issue Apr 4, 2023 · 5 comments · Fixed by #583
Assignees

Comments

@mjherzog
Copy link
Member

mjherzog commented Apr 4, 2023

When accessing large Scan files it is often hard to determine if SCWB is "working" or hung in some error state. We need some "working" icon to indicate when SCWB is actually processing a command.

@OmkarPh
Copy link
Collaborator

OmkarPh commented Apr 10, 2023

whenever, we perform a sqlite query or heavy stuff, it should show this working text & some icon ig, in a corner or bottom of the screen right

@AyanSinhaMahapatra
Copy link
Member

we perform a sqlite query or heavy stuff

Yes, this could be filters or searches, so basically queries.

working text & some icon ig, in a corner or bottom of the screen right

Just an icon is fine (usually gears moving is used for this?), we can determine where to put it from other similar tools/UI from popular tools, I'll look into this too.
Options are:

  1. change the mouse pointer to the working icon
  2. have this in a corner/edge
  3. have an overlay (partially transparent) with this icon
    or something else

@OmkarPh
Copy link
Collaborator

OmkarPh commented May 1, 2023

I think having it in a corner would be a good option
For smaller queries, the overlay would just flash in and out quickly (looks unpleasant)

@AyanSinhaMahapatra
Copy link
Member

I think having it in a corner would be a good option
For smaller queries, the overlay would just flash in and out quickly (looks unpleasant)

Yeah sounds good, finding the right size would also be nice, so that it's visible but not too unpleasant

@OmkarPh OmkarPh linked a pull request Jul 19, 2023 that will close this issue
@OmkarPh OmkarPh changed the title Need a "working" icon Worker thread support for "working" icon indicator Jul 19, 2023
@OmkarPh
Copy link
Collaborator

OmkarPh commented Jul 19, 2023

The working indicator works fine for most of the scans

For very large scans and lesser computer resources, the indicator may feel unresponsive,
It can be fixed by using worker threads as experimented in feature/workingIndicator-webworkers-test

Implementing & integrating web workers is a lot more work, and may be worked upon in the future.
For now, it's not very critical, Hence renaming the issue for further improvement

@OmkarPh OmkarPh closed this as completed Jul 19, 2023
@OmkarPh OmkarPh reopened this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants