Add option to logAndNotify on Microsoft Naming Convention errors

[Kibubu]

While I had to tweak my sync_list to reduce notifications for short lived files I was quite surprised not to see any notifications concerning skipped files due to MS's Naming Convention errors.

I would propose to add a command line parameter enabling notifications for said skipped files.

I took a look at the code and guess this is the part that needs to be adjusts

onedrive/src/sync.d

Lines 3542 to 3545 in 738be2d

	if (!isValidName(path)) {
	log.log("Skipping item - invalid name (Microsoft Naming Convention): ", path);
	return;
	}

to look more like this one

onedrive/src/main.d

Lines 1340 to 1350 in 738be2d

	};
	m.onFileChanged = delegate(string path) {
	log.vlog("[M] Local file changed: ", path);
	try {
	sync.scanForDifferences(path);
	} catch (CurlException e) {
	log.vlog("Offline, cannot upload changed item!");
	} catch(Exception e) {
	log.logAndNotify("Cannot upload file changes/creation: ", e.msg);
	}
	};

I would like to create a PR but wanted to ask if there is any interest or even maybe a better solution first.

A better solution would of course be a subscription system, similar to the sync_list with the possibility to enable/disable specific warnings, skips, errors. But this would require more work.

[abraunegg]

@Kibubu
Thanks for the suggestion.

It is rather trivial to change those lines to be log and notify by default - will look at this in the next few days

[abraunegg]

@Kibubu
This is resolved with PR #2153

• Update skip notification handling for the following scenarios:
  • Invalid Name (Microsoft Naming Convention)
  • Invalid Name (Contains an invalid whitespace item)
  • Invalid Name (Contains HTML ASCII Code)
  • Invalid Item (Invalid symbolic link)

When these items are triggered, send a notification to the GUI if it has been configured

[Kibubu]

Wonderful thank you so much.