Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: //absl/random/internal:nanobenchmark_test usually fails on a machine with low timer counter resolution #1822

Open
pcc opened this issue Feb 5, 2025 · 0 comments

Comments

@pcc
Copy link
Contributor

pcc commented Feb 5, 2025

Describe the issue

On a machine with a low enough timer counter resolution, such as Apple M2 (and I think M1), which has a 24 MHz resolution, this check usually fails:

ABSL_RAW_CHECK(est != 0, "Estimator returned zero duration");

causing the test to fail. This is because the timer counter is unlikely to tick between when the test starts and when it ends.

Steps to reproduce the problem

bazel test //absl/random/internal:nanobenchmark_test on an M1 or M2 Mac running Fedora Asahi Remix or (untested) a Linux VM on macOS or directly on macOS.

What version of Abseil are you using?

0f102ad

What operating system and version are you using?

Linux (Fedora Asahi Remix 41)

What compiler and version are you using?

clang version 19.1.7 (Fedora 19.1.7-1.fc41)

What build system are you using?

bazel 8.0.1

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant