Add protocol treasury withdrawal function so accumulated fees can be moved to a multisig

[Chucks1093]

Summary

Protocol fees accumulate in the contract but there is currently no function to withdraw them. Without a withdrawal path, fees are permanently locked unless the contract is replaced. An admin-controlled withdrawal function lets the team move accumulated XLM to a multisig wallet or treasury address on demand.

Scope

• Add withdraw_treasury(amount: i128, recipient: Address) function callable only by the protocol admin
• amount must be greater than zero and not exceed the contract's current XLM balance reserved for treasury
• Contract must track treasury balance separately from funds held for key payments and pending dividends to prevent over-withdrawal
• Emits TreasuryWithdrawal { amount, recipient, remaining_balance, ledger } event
• Add get_treasury_balance() -> i128 view function returning the withdrawable treasury balance
• Partial withdrawals are allowed; full withdrawal leaves balance at zero

Acceptance Criteria

• Admin can withdraw any amount up to the treasury balance
• Over-withdrawal reverts with a clear error
• Non-admin call reverts with Unauthorized
• Treasury balance decreases correctly after withdrawal
• TreasuryWithdrawal event emitted with correct fields
• get_treasury_balance reflects the correct withdrawable amount at all times

ETA: 24 hours

---

Coordinate on Telegram

[shinzoxD]

Hi maintainers, I would like to take this issue if it is available.

I would add admin-only withdraw_treasury(amount, recipient) support with treasury accounting kept separate from key payments and pending dividends, plus get_treasury_balance() and the requested TreasuryWithdrawal event. I would cover non-admin rejection, zero/over-withdrawal rejection, partial and full withdrawals, balance accounting after buys/sells, and event fields.

I will wait for assignment or GrantFox confirmation before opening a PR.

[KodeSage]

Hello, please assign this issue to me. I have experience implementing secure smart contract treasury management, access control, and balance accounting. My approach would be to introduce a dedicated treasury balance that is tracked independently from user funds (such as key payments and pending dividends) to ensure only withdrawable protocol fees can be transferred.

I'll implement an admin-only withdraw_treasury(amount, recipient) function with validation for authorization, positive amounts, and available treasury balance, preventing over-withdrawals. The withdrawal will emit the required TreasuryWithdrawal event with the appropriate metadata, and I'll add a get_treasury_balance() view for transparency. I'll also include comprehensive tests covering successful partial and full withdrawals, unauthorized access, insufficient treasury balance, event emission, and balance accounting to ensure all acceptance criteria are met.

ETA: 3 hours.

[syed-ghufran-hassan]

I will implement treasury withdrawal mechanism allowing protocol admin to withdraw accumulated fees. Will add withdraw_treasury(amount, recipient) with admin-only authorization, get_treasury_balance() view function, DataKey::TreasuryBalance for separate tracking, and TreasuryWithdrawalEvent with full fields. Will include comprehensive tests for all acceptance criteria. Please allocate the task to me. ETA: 1.5 hours

[chonilius]

Gm, I'll inspect how protocol fees and balances are currently accounted for, add a dedicated treasury balance tracker, implement an admin-only withdraw_treasury(amount, recipient) that validates the amount and prevents withdrawing reserved funds, emit the TreasuryWithdrawal event, add get_treasury_balance() to expose the withdrawable balance, update fee accrual logic to credit the treasury correctly, and finish by writing tests for admin authorization, invalid amounts, partial and full withdrawals, over-withdrawal prevention, reserved-funds protection, event emission, and balance updates.
kindly assign me

[grantfox-oss]

🦊 GrantFox — @chonilius has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #517)
2. Your PR will be reviewed by the accesslayerorg maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

@chonilius's PR #533 was approved and merged by @Chucks1093.

🏆 @chonilius: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (153 total points). Track your full progress on GrantFox.

👏 Great work, @chonilius! Keep contributing to accesslayerorg.