Improve retries, timeouts, and aborting #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrouget
approved these changes
Nov 17, 2025
* Add read timeout & fetch timeout (30s) * Improve aborting behavior * Add support for retrying after read() failures * Trigger AbortSignal before aborting ffmpeg process - to help ensure fetches are aborted
camgaertner
force-pushed
the
feat/reader-retries
branch
from
b006168 to
7d1a7de
Compare
* Add functions to set read/fetch timeouts for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre.js is now built separately and includes pure functions we use in jsfetch. (So it can be reviewed in our other PR)
There's a lot of refactoring in jsfetch.c, the main purpose was to add retry support when reader.read() fails, but other improvements were made around aborting, retries, & timeouts. The diff may be messy to read, because most of jsfetch.c has changed. The most important changes are in
jsfetch_open_js,jsfetch_read_js, andjsfetch_read.