Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right alingment on the officers page for smaller view ports #50

Open
V-prajit opened this issue Sep 30, 2024 · 2 comments
Open

Fix right alingment on the officers page for smaller view ports #50

V-prajit opened this issue Sep 30, 2024 · 2 comments
Assignees
@safalkark
Labels
good first issue Good for newcomers

Comments

@V-prajit
Copy link
Collaborator

  • the text and the images on the officers page are right aligned on smaller view ports, fix that and make them center alligned
@V-prajit V-prajit added the good first issue Good for newcomers label Sep 30, 2024
@safalkark
Copy link

Hello, @V-prajit , could you assign me this issue please? I am willing to work on it and I am unable to assign myself the issue. Thank you

@safalkark
Copy link

How do I push the changes I made? I've made all the changes required for this issue but I do not know how I should push my changes forward

safalkark added a commit to safalkark/acmuta-site that referenced this issue Oct 9, 2024
@safalkark
Issue acmuta#50
ed33418 
Changed line 10 on page.tsx in the officers folder to default to text center for the first paragraph and on large screens to text-left for the header and same thing on line 11 for the paragraph.

 Changed line 25 on Department.tsx on the officers folder. Added a default left margin for 5rem and added a conditional for large screens to have a left margin of 0.

Changed People.tsx to fix margins as well. Changed line 22 on the page to have a default left margin of 3.75rem and on large screens to have a left margin of 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safalkark safalkark

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@V-prajit @safalkark