match only terminal Binance withdrawals

Author: nicholaspai

src/rebalancer/adapters/binance.ts

@@ -70,6 +70,18 @@ export function isFailedBinanceWithdrawal(status?: number): boolean {
   }
 }
 
+export function isTerminalBinanceWithdrawal(status?: number): boolean {
+  switch (status) {
+    case BINANCE_WITHDRAWAL_STATUS.CANCELLED:
+    case BINANCE_WITHDRAWAL_STATUS.REJECTED:
+    case BINANCE_WITHDRAWAL_STATUS.FAILURE:
+    case BINANCE_WITHDRAWAL_STATUS.COMPLETED:
+      return true;
+    default:
+      return false;
+  }
+}
+
 export class BinanceStablecoinSwapAdapter extends BaseAdapter {
   private binanceApiClient: Binance;
 
@@ -1014,7 +1026,8 @@ export class BinanceStablecoinSwapAdapter extends BaseAdapter {
       (withdrawal) =>
         withdrawal.coin === token &&
         withdrawal.network === BINANCE_NETWORKS[chain] &&
-        withdrawal.recipient === this.baseSignerAddress.toNative()
+        withdrawal.recipient === this.baseSignerAddress.toNative() &&
+        isTerminalBinanceWithdrawal(withdrawal.status)
     );
   }
 

test/BinanceAdapter.withdrawals.ts

@@ -1,5 +1,5 @@
 import { expect } from "./utils";
-import { isFailedBinanceWithdrawal } from "../src/rebalancer/adapters/binance";
+import { isFailedBinanceWithdrawal, isTerminalBinanceWithdrawal } from "../src/rebalancer/adapters/binance";
 
 describe("Binance adapter withdrawal state", function () {
   it("treats terminal Binance withdrawal failures as failed", function () {
@@ -15,4 +15,15 @@ describe("Binance adapter withdrawal state", function () {
     expect(isFailedBinanceWithdrawal(6)).to.equal(false);
     expect(isFailedBinanceWithdrawal(undefined)).to.equal(false);
   });
+
+  it("only treats terminal Binance withdrawals as terminal", function () {
+    expect(isTerminalBinanceWithdrawal(1)).to.equal(true);
+    expect(isTerminalBinanceWithdrawal(3)).to.equal(true);
+    expect(isTerminalBinanceWithdrawal(5)).to.equal(true);
+    expect(isTerminalBinanceWithdrawal(6)).to.equal(true);
+    expect(isTerminalBinanceWithdrawal(0)).to.equal(false);
+    expect(isTerminalBinanceWithdrawal(2)).to.equal(false);
+    expect(isTerminalBinanceWithdrawal(4)).to.equal(false);
+    expect(isTerminalBinanceWithdrawal(undefined)).to.equal(false);
+  });
 });