New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to autocomplete-valid-value-73f2c2.md #2221

Merged

WilcoFiers merged 1 commit into develop from autocomplete-valid-value-73f2c2-tweaks

Oct 31, 2024

Member

WilcoFiers commented Oct 24, 2024

The accessibility support note is outdated. Firefox was the last browser that was treating ARIA values as case sensitive. That was resolved over a year ago AFAIK.
Couple typos.

Need for Call for Review: none, editorial change

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.


          Tweaks to autocomplete-valid-value-73f2c2.md

bd3e171

carlosapaduarte approved these changes

View reviewed changes

dan-tripp-siteimprove self-requested a review

October 24, 2024 15:09

dan-tripp-siteimprove approved these changes

View reviewed changes

giacomo-petri approved these changes

View reviewed changes

WilcoFiers merged commit 6be0845 into develop

2 checks passed

WilcoFiers deleted the autocomplete-valid-value-73f2c2-tweaks branch

October 31, 2024 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet