[Editorial] - [5f99a7] ARIA attribute is defined in WAI-ARIA - Passed Example 2 improvement #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-petri
requested review from
WilcoFiers,
carlosapaduarte,
dd8,
tombrunet,
Jym77 and
dan-tripp-siteimprove
giacomo-petri
added
the
Editorial
Jym77
approved these changes
Feb 6, 2025
carlosapaduarte
approved these changes
Feb 6, 2025
dan-tripp-siteimprove
approved these changes
Feb 10, 2025
dd8
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue(s): #2239
Description:
This PR adds the required acc name to the element with explicit role="dialog"
from
<div role="dialog" aria-modal="true">Contains modal content...</div>to
<div role="dialog" aria-modal="true" aria-label="Modal title">Contains modal content...</div>Need for Call for Review:
This can be merged with 1 approval