Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editorial] - [5c01ea] ARIA state or property is permitted - Passed Example 6-7-8 improvement #2255

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Collaborator

Closes issue(s): #2254

Description:

This PR adds the required acc name from author to the element with explicit role="combobox"
from

<div role="combobox" aria-controls="id1" aria-expanded="false">My combobox</div>
<div role="combobox" aria-expanded="false" aria-controls>My combobox</div>
<div role="combobox" aria-expanded="false" aria-controls="">My combobox</div>

to

<div role="combobox" aria-controls="id1" aria-expanded="false" aria-label="My combobox">My combobox</div>
<div role="combobox" aria-expanded="false" aria-controls aria-label="My combobox">My combobox</div>
<div role="combobox" aria-expanded="false" aria-controls="" aria-label="My combobox">My combobox</div>

Need for Call for Review:

This can be merged with 1 approval

@giacomo-petri giacomo-petri added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Feb 1, 2025
Jym77
Jym77 previously approved these changes Feb 6, 2025
@Jym77 Jym77 dismissed their stale review February 20, 2025 12:56

Duplicate organisation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants